on i386 USRSTACK points one page below the VM_MAXUSER_ADDRESS
AbandonedPublic
Actions

Authored by op on Jun 30 2015, 3:53 PM.

Tags

None

Referenced Files

	F167326418: D2960.diff
	Thu, Aug 20, 10:30 PM

	Unknown Object (File)
	Fri, Aug 14, 2:35 AM

	Unknown Object (File)
	Tue, Aug 4, 7:14 AM

	Unknown Object (File)
	Tue, Aug 4, 5:29 AM

	Unknown Object (File)
	Mon, Aug 3, 7:09 AM

	Unknown Object (File)
	Jul 13 2026, 12:10 PM

	Unknown Object (File)
	Jul 5 2026, 7:22 AM

	Unknown Object (File)
	May 21 2026, 8:53 AM

View All Files

Subscribers

imp

Details

Reviewers

kib
jhb
gnn
rwatson

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

op updated this revision to Diff 6592.Jun 30 2015, 3:53 PM

op retitled this revision from to on i386 USRSTACK points one page below the VM_MAXUSER_ADDRESS.

op updated this object.

op edited the test plan for this revision. (Show Details)

op added reviewers: kib, jhb, rwatson.

op set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: gnn. · View Herald TranscriptJun 30 2015, 3:53 PM

Herald added a subscriber: imp. · View Herald Transcript

This looks fine. Would you move IN_KERNEL() macro into some common location and then just #define PMC_IN_KERNEL(va) IN_KERNEL(va) ?

I have found this error in one more place. Added the fix to the updated patch.

The potential common place could be the pmap.h or something else?
I have found this macro in sys/$arch/stack.h file, but I not really like the header pollution across independent header files.

Typo fix.

I put the commit candidate patch at https://reviews.freebsd.org/D2971 .

This was superseded with D2971, so close them.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

dtrace/

i386/

dtrace_isa.c

2 lines

i386/

include/

pmc_mdep.h

2 lines

Diff 6592

View Options

sys/cddl/dev/dtrace/i386/dtrace_isa.c