Fix undefined behavior: left-shifting into the sign bit.
ClosedPublic
Actions

Authored by kib on Dec 21 2019, 5:05 PM.

Tags

None

Referenced Files

	F137254819: D22898.id65892.diff
	Fri, Nov 21, 8:34 PM

	Unknown Object (File)
	Thu, Nov 20, 8:31 PM

	Unknown Object (File)
	Thu, Nov 20, 8:27 PM

	Unknown Object (File)
	Thu, Nov 20, 8:25 PM

	Unknown Object (File)
	Thu, Nov 20, 8:13 PM

	Unknown Object (File)
	Sun, Nov 16, 12:00 AM

	Unknown Object (File)
	Sun, Oct 26, 11:26 AM

	Unknown Object (File)
	Sat, Oct 25, 1:29 PM

View All 78 Files

Subscribers

imp

Details

Reviewers

emaste
dim
markj

Commits

rS356039: Fix undefined behavior: left-shifting into the sign bit.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 28277

Event Timeline

kib created this revision.Dec 21 2019, 5:05 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 21 2019, 5:05 PM

Harbormaster completed remote builds in B28277: Diff 65892.Dec 21 2019, 5:06 PM

markj accepted this revision.Dec 21 2019, 6:58 PM

This revision is now accepted and ready to land.Dec 21 2019, 6:58 PM

LGTM. Are any users of the macros affected, btw?

In D22898#501463, @dim wrote:

Are any users of the macros affected, btw?

I do not think that anything is affected for real, otherwise we would already have reports e.g. about threading breakage due to SIGTHR == 32.
This is only a preventive measure against compiler writers trying to make our life hard.

Closed by commit rS356039: Fix undefined behavior: left-shifting into the sign bit. (authored by kib). · Explain WhyDec 23 2019, 8:18 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS356039: Fix undefined behavior: left-shifting into the sign bit..

Revision Contents
Changeset List

Path

Size

sys/

_sigset.h

2 lines

bitset.h

2 lines

Diff 65892

View Options

sys/sys/_sigset.h