Page MenuHomeFreeBSD

Fix undefined behavior: left-shifting into the sign bit.
ClosedPublic

Authored by kib on Dec 21 2019, 5:05 PM.
Tags
None
Referenced Files
F105528666: D22898.diff
Tue, Dec 17, 7:49 AM
Unknown Object (File)
Mon, Dec 2, 3:50 AM
Unknown Object (File)
Sep 15 2024, 4:12 AM
Unknown Object (File)
Sep 6 2024, 12:31 AM
Unknown Object (File)
Sep 2 2024, 12:22 PM
Unknown Object (File)
Sep 2 2024, 12:22 PM
Unknown Object (File)
Sep 2 2024, 12:22 PM
Unknown Object (File)
Sep 2 2024, 12:11 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 28277

Event Timeline

This revision is now accepted and ready to land.Dec 21 2019, 6:58 PM

LGTM. Are any users of the macros affected, btw?

In D22898#501463, @dim wrote:

Are any users of the macros affected, btw?

I do not think that anything is affected for real, otherwise we would already have reports e.g. about threading breakage due to SIGTHR == 32.
This is only a preventive measure against compiler writers trying to make our life hard.