Page MenuHomeFreeBSD

Fix undefined behavior: left-shifting into the sign bit.
ClosedPublic

Authored by kib on Dec 21 2019, 5:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 26, 1:13 AM
Unknown Object (File)
Tue, Sep 16, 12:09 PM
Unknown Object (File)
Sep 4 2025, 5:29 AM
Unknown Object (File)
Jul 31 2025, 6:53 PM
Unknown Object (File)
Jul 28 2025, 2:37 PM
Unknown Object (File)
Jul 27 2025, 4:35 PM
Unknown Object (File)
Jul 26 2025, 9:59 PM
Unknown Object (File)
Jul 4 2025, 5:02 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Dec 21 2019, 6:58 PM

LGTM. Are any users of the macros affected, btw?

In D22898#501463, @dim wrote:

Are any users of the macros affected, btw?

I do not think that anything is affected for real, otherwise we would already have reports e.g. about threading breakage due to SIGTHR == 32.
This is only a preventive measure against compiler writers trying to make our life hard.