Differential D22892

Deduplicate code between if_delgroup() and if_delgroups().
ClosedPublic
Actions

Authored by markj on Dec 20 2019, 5:15 PM.

Details

Reviewers

• hselasky

Group Reviewers

network

Commits

rS355942: Deduplicate code between if_delgroup() and if_delgroups().

Summary

Fix some style in if_addgroup(). No functional change intended.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28268
Build 26384: arc lint + arc unit

Event Timeline

markj created this revision.Dec 20 2019, 5:15 PM

Herald added a subscriber: ae. · View Herald TranscriptDec 20 2019, 5:15 PM

Harbormaster completed remote builds in B28264: Diff 65862.Dec 20 2019, 5:15 PM

markj added reviewers: network, • hselasky.Dec 20 2019, 5:16 PM

• hselasky accepted this revision.Dec 20 2019, 5:22 PM

• hselasky added inline comments.

sys/net/if.c
1510	Maybe call this function _if_delgroup_wlocked() because it is called locked?

This revision is now accepted and ready to land.Dec 20 2019, 5:22 PM

Give _if_delgroup() a slightly more descriptive name.

This revision now requires review to proceed.Dec 20 2019, 5:28 PM

Harbormaster completed remote builds in B28265: Diff 65863.Dec 20 2019, 5:28 PM

• hselasky accepted this revision.Dec 20 2019, 5:31 PM

• hselasky added inline comments.

sys/net/if.c
1581–1582	Technically this is the same like: while ((ifgl = CK_STAILQ_FIRST(&ifp->if_groups)) != NULL) {

This revision is now accepted and ready to land.Dec 20 2019, 5:31 PM

Simplify the loop header in if_delgroups().

This revision now requires review to proceed.Dec 20 2019, 5:41 PM

Harbormaster completed remote builds in B28268: Diff 65866.Dec 20 2019, 5:41 PM

• hselasky accepted this revision.Dec 20 2019, 5:42 PM

This revision is now accepted and ready to land.Dec 20 2019, 5:42 PM

Closed by commit rS355942: Deduplicate code between if_delgroup() and if_delgroups(). (authored by markj). · Explain WhyDec 20 2019, 8:15 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS355942: Deduplicate code between if_delgroup() and if_delgroups()..

Herald added a subscriber: imp. · View Herald TranscriptDec 20 2019, 8:15 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

108 lines

Diff 65866

View Options

Deduplicate code between if_delgroup() and if_delgroups().ClosedPublicActions