Page MenuHomeFreeBSD
Differential D22688

multimedia/x264 - use base compiler on PowerPC64/ELFv2
ClosedPublic
Actions

Authored by alfredo on Dec 5 2019, 12:50 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Dec 30, 3:59 PM
Unknown Object (File)
Nov 26 2024, 11:23 AM
Unknown Object (File)
Nov 25 2024, 3:18 PM
Unknown Object (File)
Nov 23 2024, 11:55 AM
Unknown Object (File)
Nov 23 2024, 11:55 AM
Unknown Object (File)
Nov 23 2024, 11:55 AM
Unknown Object (File)
Nov 23 2024, 11:51 AM
Unknown Object (File)
Nov 23 2024, 11:51 AM
View All 90 Files
Subscribers
bdragon
koobs
luporl

Details

Reviewers
koobs
linimon
pkubaj
mikael
Commits
rP520083: multimedia/x264 - use base compiler on powerpc* when using clang
Summary

Environment running PowerPC64 with the ELFv2 uses llvm9 as base compiler, so we can remove GCC dependency.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28110
Build 26249: arc lint + arc unit

Event Timeline

alfredo created this revision.Dec 5 2019, 12:50 PM
Herald added subscribers: luporl, bdragon. · View Herald TranscriptDec 5 2019, 12:50 PM
Harbormaster completed remote builds in B27976: Diff 65260.Dec 5 2019, 12:50 PM
pkubaj requested changes to this revision.Dec 5 2019, 2:03 PM

powerpc and powerpcspe also switch to LLVM, so we should change default options there as well.

This revision now requires changes to proceed.Dec 5 2019, 2:03 PM
alfredo updated this revision to Diff 65547.Dec 12 2019, 3:13 PM

check compiler type

Harbormaster completed remote builds in B28102: Diff 65547.Dec 12 2019, 3:13 PM
alfredo updated this revision to Diff 65563.Dec 12 2019, 8:03 PM

remove explicit GCC dependency and add "modern compiler dependency" instead (compiler:c11)

Harbormaster completed remote builds in B28110: Diff 65563.Dec 12 2019, 8:03 PM
pkubaj requested changes to this revision.Dec 12 2019, 8:52 PM

Now it's not necessary to put include bsd.port.pre.mk and bsd.port.post.mk separately.

This revision now requires changes to proceed.Dec 12 2019, 8:52 PM
pkubaj added a comment.Dec 12 2019, 8:53 PM

Also, PGO options seems to require GCC. Why do you remove USE_GCC=any there? Have you verified it's not needed?

alfredo added a comment.Dec 13 2019, 5:23 PM
In D22688#498747, @pkubaj wrote:

Also, PGO options seems to require GCC. Why do you remove USE_GCC=any there? Have you verified it's not needed?

I'll revert this part to keep safe, affects behavior on platforms other than powerpc*

alfredo updated this revision to Diff 65598.Dec 13 2019, 5:27 PM

reverted PGO part

Harbormaster completed remote builds in B28127: Diff 65598.Dec 13 2019, 5:27 PM
koobs added a comment.Dec 14 2019, 12:19 AM

Can we get a proposed commit log message in this reviews summary that explains the context/issue and the 'why' of the change please

@pkubaj I'm happy for you to take this. Would you mind taking this to resolution, pending appropriate QA (poudriere, etc)?

pkubaj added a comment.Dec 14 2019, 1:19 AM
In D22688#499365, @koobs wrote:

Can we get a proposed commit log message in this reviews summary that explains the context/issue and the 'why' of the change please

@pkubaj I'm happy for you to take this. Would you mind taking this to resolution, pending appropriate QA (poudriere, etc)?

No problem, could you then resign from being a reviewer here?

pkubaj accepted this revision.Dec 14 2019, 1:21 AM

Still includes unnecessarily bsd.port.pre.mk. but I will fix it in the commit.

This revision is now accepted and ready to land.Dec 14 2019, 1:21 AM
koobs added a comment.Dec 14 2019, 1:34 AM

@pkubaj I believe you can "Commandeer Revision"

koobs added a subscriber: koobs.Dec 14 2019, 1:34 AM
In D22688#499387, @koobs wrote:

@pkubaj I believe you can "Commandeer Revision"

Not that you need to.

Approved by: koobs (maintainer)

Pending QA

Closed by commit rP520083: multimedia/x264 - use base compiler on powerpc* when using clang (authored by pkubaj). · Explain WhyDec 14 2019, 1:47 AM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP520083: multimedia/x264 - use base compiler on powerpc* when using clang.

Revision Contents
Changeset List

PathSize
multimedia/
x264/
16 lines

Diff 65563

View Options

multimedia/x264/Makefile

Loading...