Page MenuHomeFreeBSD

multimedia/x264 - use base compiler on PowerPC64/ELFv2
ClosedPublic

Authored by alfredo on Dec 5 2019, 12:50 PM.
Referenced Files
Unknown Object (File)
Thu, Mar 14, 11:31 PM
Unknown Object (File)
Thu, Mar 14, 11:28 PM
Unknown Object (File)
Thu, Mar 14, 11:27 PM
Unknown Object (File)
Thu, Mar 14, 11:27 PM
Unknown Object (File)
Thu, Mar 14, 11:27 PM
Unknown Object (File)
Thu, Mar 14, 11:27 PM
Unknown Object (File)
Mon, Mar 11, 8:18 AM
Unknown Object (File)
Feb 15 2024, 7:36 PM

Details

Summary

Environment running PowerPC64 with the ELFv2 uses llvm9 as base compiler, so we can remove GCC dependency.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28102
Build 26244: arc lint + arc unit

Event Timeline

pkubaj requested changes to this revision.Dec 5 2019, 2:03 PM

powerpc and powerpcspe also switch to LLVM, so we should change default options there as well.

This revision now requires changes to proceed.Dec 5 2019, 2:03 PM

remove explicit GCC dependency and add "modern compiler dependency" instead (compiler:c11)

pkubaj requested changes to this revision.Dec 12 2019, 8:52 PM

Now it's not necessary to put include bsd.port.pre.mk and bsd.port.post.mk separately.

This revision now requires changes to proceed.Dec 12 2019, 8:52 PM

Also, PGO options seems to require GCC. Why do you remove USE_GCC=any there? Have you verified it's not needed?

Also, PGO options seems to require GCC. Why do you remove USE_GCC=any there? Have you verified it's not needed?

I'll revert this part to keep safe, affects behavior on platforms other than powerpc*

Can we get a proposed commit log message in this reviews summary that explains the context/issue and the 'why' of the change please

@pkubaj I'm happy for you to take this. Would you mind taking this to resolution, pending appropriate QA (poudriere, etc)?

Can we get a proposed commit log message in this reviews summary that explains the context/issue and the 'why' of the change please

@pkubaj I'm happy for you to take this. Would you mind taking this to resolution, pending appropriate QA (poudriere, etc)?

No problem, could you then resign from being a reviewer here?

Still includes unnecessarily bsd.port.pre.mk. but I will fix it in the commit.

This revision is now accepted and ready to land.Dec 14 2019, 1:21 AM

@pkubaj I believe you can "Commandeer Revision"

@pkubaj I believe you can "Commandeer Revision"

Not that you need to.

Approved by: koobs (maintainer)

Pending QA