Page MenuHomeFreeBSD
Differential D22714

sysent: Reduce duplication and improve readability.
ClosedPublic
Actions

Authored by brooks on Dec 6 2019, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 3:50 AM
Unknown Object (File)
Fri, Nov 22, 3:50 AM
Unknown Object (File)
Fri, Nov 22, 3:49 AM
Unknown Object (File)
Fri, Nov 22, 3:49 AM
Unknown Object (File)
Fri, Nov 22, 3:48 AM
Unknown Object (File)
Fri, Nov 22, 3:28 AM
Unknown Object (File)
Tue, Nov 19, 2:34 PM
Unknown Object (File)
Mon, Nov 4, 6:18 PM
View All 71 Files
Subscribers
andrew
imp

Details

Reviewers
kevans
bdrewery
emaste
manu
Commits
rS355473: sysent: Reduce duplication and improve readability.
Summary

Use the power of variable to avoid spelling out source and generated
files multiple times. The previous Makefiles were hard to read, hard to
edit, and badly formatted.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28019
Build 26176: arc lint + arc unit

Event Timeline

brooks created this revision.Dec 6 2019, 10:17 PM
Herald added a reviewer: manu. · View Herald TranscriptDec 6 2019, 10:17 PM
Herald added a subscriber: andrew. · View Herald Transcript
Harbormaster completed remote builds in B28018: Diff 65335.Dec 6 2019, 10:17 PM
kevans added inline comments.Dec 6 2019, 10:22 PM
sys/amd64/linux/Makefile
24–25

This one should also have a dependency on ${MAKESYSCALLS}

brooks updated this revision to Diff 65337.Dec 6 2019, 10:49 PM
  • Add missing dependency
Harbormaster completed remote builds in B28019: Diff 65337.Dec 6 2019, 10:49 PM
brooks updated this revision to Diff 65338.Dec 6 2019, 10:53 PM
brooks marked an inline comment as done.
  • Improve whitespace consistency.
Harbormaster completed remote builds in B28020: Diff 65338.Dec 6 2019, 10:53 PM
kevans accepted this revision.Dec 6 2019, 11:00 PM
This revision is now accepted and ready to land.Dec 6 2019, 11:00 PM
emaste accepted this revision.Dec 6 2019, 11:29 PM
Closed by commit rS355473: sysent: Reduce duplication and improve readability. (authored by brooks). · Explain WhyDec 6 2019, 11:59 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rS355473: sysent: Reduce duplication and improve readability..
Herald added a subscriber: imp. · View Herald TranscriptDec 6 2019, 11:59 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
16 lines
linux32/
16 lines
arm64/
linux/
16 lines
compat/
cloudabi32/
21 lines
cloudabi64/
21 lines
freebsd32/
21 lines
i386/
linux/
16 lines
kern/
18 lines

Diff 65337

View Options

sys/amd64/linux/Makefile

Loading...
View Options

sys/amd64/linux32/Makefile

Loading...
View Options

sys/arm64/linux/Makefile

Loading...
View Options

sys/compat/cloudabi32/Makefile

Loading...
View Options

sys/compat/cloudabi64/Makefile

Loading...
View Options

sys/compat/freebsd32/Makefile

Loading...
View Options

sys/i386/linux/Makefile

Loading...
View Options

sys/kern/Makefile

Loading...