Page MenuHomeFreeBSD
Differential D22703

uma dbg: catch more corruption with atomics
ClosedPublic
Actions

Authored by rlibby on Dec 6 2019, 9:49 AM.
Tags
None
Referenced Files
F132281496: D22703.id.diff
Wed, Oct 15, 11:56 AM
F132281480: D22703.id81443.diff
Wed, Oct 15, 11:56 AM
F132281475: D22703.id81397.diff
Wed, Oct 15, 11:56 AM
F132281468: D22703.id65305.diff
Wed, Oct 15, 11:56 AM
Unknown Object (File)
Wed, Oct 15, 1:01 AM
Unknown Object (File)
Sun, Oct 12, 5:15 AM
Unknown Object (File)
Sat, Sep 27, 12:24 AM
Unknown Object (File)
Fri, Sep 19, 8:54 AM
View All Files
Subscribers
cem
imp
kib

Details

Reviewers
jeff
markj
kib
cem
Commits
rG942951ba46ec: uma dbg: catch more corruption with atomics
Summary

Use atomic testandset and testandclear to catch concurrent double free,
and to reduce the number of atomic operations.

Submitted by: jeff

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28002
Build 26161: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 6 2019, 9:49 AM
Harbormaster completed remote builds in B28002: Diff 65305.Dec 6 2019, 9:49 AM
kib accepted this revision.Dec 6 2019, 1:17 PM
This revision is now accepted and ready to land.Dec 6 2019, 1:17 PM
markj accepted this revision.Dec 6 2019, 3:28 PM
cem accepted this revision.Dec 6 2019, 6:06 PM
cem added a parent revision: D22702: bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC.
rlibby mentioned this in D22702: bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC.Dec 7 2019, 5:28 AM
rlibby mentioned this in D22963: Expand generic subword atomic primitives.Feb 5 2020, 7:24 PM
rlibby updated this revision to Diff 81397.Dec 31 2020, 12:49 AM

Rebase, over

This revision now requires review to proceed.Dec 31 2020, 12:49 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 31 2020, 12:49 AM
Harbormaster completed remote builds in B35810: Diff 81397.Dec 31 2020, 12:49 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 31 2020, 9:04 PM
Closed by commit rG942951ba46ec: uma dbg: catch more corruption with atomics (authored by rlibby). · Explain Why
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rG942951ba46ec: uma dbg: catch more corruption with atomics.

Revision Contents
Changeset List

PathSize
sys/
vm/
9 lines

Diff 65305

View Options

sys/vm/uma_core.c

Loading...