uma dbg: catch more corruption with atomics
ClosedPublic
Actions

Authored by rlibby on Dec 6 2019, 9:49 AM.

Details

Reviewers

jeff
markj
kib
cem

Commits

rG942951ba46ec: uma dbg: catch more corruption with atomics

Summary

Use atomic testandset and testandclear to catch concurrent double free,
and to reduce the number of atomic operations.

Submitted by: jeff

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Dec 6 2019, 9:49 AM

Harbormaster completed remote builds in B28002: Diff 65305.Dec 6 2019, 9:49 AM

kib accepted this revision.Dec 6 2019, 1:17 PM

This revision is now accepted and ready to land.Dec 6 2019, 1:17 PM

markj accepted this revision.Dec 6 2019, 3:28 PM

cem accepted this revision.Dec 6 2019, 6:06 PM

cem added a parent revision: D22702: bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC.

rlibby mentioned this in D22702: bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC.Dec 7 2019, 5:28 AM

rlibby mentioned this in D22963: Expand generic subword atomic primitives.Feb 5 2020, 7:24 PM

Rebase, over

r355746 / git 815db20425013129469fc0ebe9f8f00c88c58184
r366377 / git 952c8964ba935937e396c8abc8d5629e59502e2d

This revision now requires review to proceed.Dec 31 2020, 12:49 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 31 2020, 12:49 AM

Harbormaster completed remote builds in B35810: Diff 81397.Dec 31 2020, 12:49 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 31 2020, 9:04 PM

Closed by commit rG942951ba46ec: uma dbg: catch more corruption with atomics (authored by rlibby). · Explain Why

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG942951ba46ec: uma dbg: catch more corruption with atomics.

Revision Contents
Changeset List

Path

Size

sys/

vm/

uma_core.c

9 lines

Diff 81443

View Options

uma dbg: catch more corruption with atomicsClosedPublicActions