Page MenuHomeFreeBSD
Differential D22680

graphics/R-cran-bmp: New port
AcceptedPublic
Actions

Authored by dteske on Dec 4 2019, 6:37 PM.
Tags
None
Referenced Files
F173232796: D22680.id.diff
Thu, Sep 24, 1:09 PM
Unknown Object (File)
Tue, Sep 22, 8:46 PM
Unknown Object (File)
Mon, Sep 21, 6:23 AM
Unknown Object (File)
Mon, Sep 21, 12:53 AM
Unknown Object (File)
Thu, Sep 17, 9:52 AM
Unknown Object (File)
Tue, Sep 15, 7:03 AM
Unknown Object (File)
Mon, Sep 14, 7:27 PM
Unknown Object (File)
Mon, Sep 14, 5:53 AM
View All Files
Subscribers
adamw

Details

Reviewers
imp
swills
mat
jrm
fuz
Summary

bmp provides the ability to read Windows BMP format images in R.
Currently limited to 8 bit greyscale images and 24,32 bit (A)RGB
images. Pure R implementation without external dependencies.

Test Plan

install, deinstall, package, pkg install, pkg delete

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27953
Build 26119: arc lint + arc unit

Event Timeline

dteske created this revision.Dec 4 2019, 6:37 PM
Harbormaster completed remote builds in B27953: Diff 65227.Dec 4 2019, 6:37 PM
mat added inline comments.Dec 4 2019, 6:47 PM
graphics/R-cran-bmp/Makefile
6

Extra blank line, remove.

dteske updated this revision to Diff 65234.Dec 4 2019, 7:06 PM

Remove extra newline as-per mat's instruction

Harbormaster completed remote builds in B27959: Diff 65234.Dec 4 2019, 7:06 PM
dteske marked an inline comment as done.Dec 4 2019, 7:06 PM
mat accepted this revision.Dec 4 2019, 8:04 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:04 PM
dteske removed a reviewer: mat.Dec 4 2019, 8:23 PM
This revision now requires review to proceed.Dec 4 2019, 8:23 PM
mat accepted this revision.Dec 4 2019, 8:31 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:31 PM
dteske retitled this revision from [New Port] graphics/R-cran-bmp: Read Windows Bitmap (BMP) Images to graphics/R-cran-bmp: New port.Jul 29 2026, 12:58 AM
dteske updated this revision to Diff 183010.Jul 29 2026, 1:02 AM

graphics/R-cran-bmp: New port

Read Windows BMP format images in R (8-bit greyscale and 24/32-bit
(A)RGB). Pure R implementation with no external dependencies.

Refresh against current ports tree and CRAN bmp 0.3.1 (was 0.3).

Since @mat's accept in 2019:

  • bump to 0.3.1
  • modern Makefile (WWW=, drop $FreeBSD$)
  • add graphics/Makefile SUBDIR

Tested with DEVELOPER=yes: makesum, stage, stage-qa (clean), package.

@mat: would you mind re-accepting when you have a moment?

This revision now requires review to proceed.Jul 29 2026, 1:02 AM
Harbormaster completed remote builds in B75252: Diff 183010.Jul 29 2026, 1:02 AM
dteske added a reviewer: jrm.Aug 24 2026, 9:24 PM
dteske added a reviewer: fuz.Wed, Sep 16, 12:11 AM
fuz added inline comments.Wed, Sep 16, 10:46 AM
graphics/R-cran-bmp/Makefile
3
5

DISTVERSION should be preferred if possible.

jrm accepted this revision.Wed, Sep 23, 5:18 PM

+1 to fuz's comment about DISTVERSION.

This revision is now accepted and ready to land.Wed, Sep 23, 5:18 PM
jrm added a comment.Wed, Sep 23, 5:31 PM

Also, if you want to support the tests through make test, you can add this:

TEST_DEPENDS= R-cran-pixmap>0:graphics/R-cran-pixmap \
             R-cran-testthat>0:devel/R-cran-testthat

Revision Contents
Changeset List

PathSize
graphics/
R-cran-bmp/
17 lines
3 lines
5 lines

Diff 65227

View Options

graphics/R-cran-bmp/

Loading...
View Options

graphics/R-cran-bmp/Makefile

Loading...
View Options

graphics/R-cran-bmp/distinfo

Loading...
View Options

graphics/R-cran-bmp/pkg-descr

Loading...