Differential D22607

base/binutils: Simplify a few things and fix cross-building.
ClosedPublic
Actions

Authored by jhb on Nov 29 2019, 4:29 PM.

Details

Reviewers

bapt

Commits

rP518973: Simplify a few things and fix cross-building.

Summary

Remove objcopy unconditionally.
Don't bother creating links with the BUTARGET prefix.
Use HOSTARCH when setting CONFIGURE_TARGET.

Test Plan

cross-built i386 and mips packages, native built amd64 and verified with check-plist

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 27852
Build 26027: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 29 2019, 4:29 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 29 2019, 4:29 PM

Harbormaster completed remote builds in B27852: Diff 65053.Nov 29 2019, 4:29 PM

lwhsu added a subscriber: lwhsu.Dec 2 2019, 8:24 AM

bapt accepted this revision.Dec 3 2019, 8:10 AM

This revision is now accepted and ready to land.Dec 3 2019, 8:10 AM

Closed by commit rP518973: Simplify a few things and fix cross-building. (authored by jhb). · Explain WhyDec 3 2019, 11:22 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rP518973: Simplify a few things and fix cross-building..

bdragon mentioned this in D19291: Since the compatibility code for FreeBSD < 11.2 was removed, we can unconditionally omit objcopy in base/binutils..Dec 12 2019, 5:56 PM

Revision Contents
Changeset List

Path

Size

base/

binutils/

Makefile

27 lines

pkg-plist

12 lines

Diff 65053

View Options

base/binutils/Makefile