Differential D22497

Moving all ECN related flags to flags2
ClosedPublic
Actions

Authored by rscheff on Nov 22 2019, 5:53 AM.

Tags

None

Referenced Files

	F154534914: D22497.diff
	Tue, Apr 28, 8:39 PM

	Unknown Object (File)
	Sat, Apr 25, 5:37 AM

	Unknown Object (File)
	Sat, Apr 25, 4:46 AM

	Unknown Object (File)
	Fri, Apr 24, 8:53 AM

	Unknown Object (File)
	Thu, Apr 23, 6:31 AM

	Unknown Object (File)
	Tue, Apr 21, 3:29 AM

	Unknown Object (File)
	Mon, Apr 20, 8:23 PM

	Unknown Object (File)
	Sun, Apr 12, 7:55 PM

Subscribers

Details

Reviewers

lstewart
rrs
tuexen
rgrimes

Group Reviewers

Commits

rS355273: Move all ECN related flags from the flags to the flags2 field.

Summary

The first flags field in the tcpcb is nearly full.
In preparation of ECN related enhancements, moving
all these flags to the flags2 tcpcb field - so that
additional counters can also be defined in the same
cacheline later on, which are related to ECN.

This leaves a total of 5 unused bits in the flags field

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27710
Build 25910: arc lint + arc unit

Event Timeline

rscheff created this revision.Nov 22 2019, 5:53 AM

Herald added a reviewer: transport. · View Herald TranscriptNov 22 2019, 5:53 AM

Harbormaster completed remote builds in B27709: Diff 64715.Nov 22 2019, 5:53 AM

renaming unused flags

Harbormaster completed remote builds in B27710: Diff 64716.Nov 22 2019, 5:57 AM

rrs accepted this revision.Nov 22 2019, 11:29 AM

This revision is now accepted and ready to land.Nov 22 2019, 11:29 AM

tuexen accepted this revision.Dec 1 2019, 8:51 PM

Closed by commit rS355273: Move all ECN related flags from the flags to the flags2 field. (authored by tuexen). · Explain WhyDec 1 2019, 9:01 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS355273: Move all ECN related flags from the flags to the flags2 field..

Herald added a subscriber: imp. · View Herald TranscriptDec 1 2019, 9:01 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

cc/

16 lines

16 lines

8 lines

tcp_stacks/

24 lines

2 lines

24 lines

12 lines

Diff 64716

sys/netinet/cc/cc_dctcp.c

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_output.c

Loading...

sys/netinet/tcp_stacks/rack.c

Loading...

sys/netinet/tcp_syncache.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/tcp_var.h

Loading...