Paths

Table of Contentst

Differential D22382

Fix build race in bsd.files.mk
ClosedPublic
Actions

Authored by arichardson on Nov 15 2019, 3:45 PM.

Tags

None

Referenced Files

	F163693722: D22382.id64373.diff
	Sat, Jul 25, 1:07 PM

	Unknown Object (File)
	Mon, Jul 20, 11:07 AM

	Unknown Object (File)
	Sun, Jul 19, 4:18 PM

	Unknown Object (File)
	Sun, Jul 19, 9:19 AM

	Unknown Object (File)
	Sat, Jul 18, 10:32 AM

	Unknown Object (File)
	Wed, Jul 15, 3:11 PM

	Unknown Object (File)
	Wed, Jul 15, 8:35 AM

	Unknown Object (File)
	Fri, Jul 10, 3:37 PM

Subscribers

Details

Reviewers

sjg
brd
brooks

Commits

rS354740: Fix build race in bsd.files.mk

Summary

We need to ensure that installdirs-FOO runs before installfiles-FOO since
otherwise the directory may not exist when we attempt to install the target.
This was randomly causing failures in our Jenkins instance when installing
drti.o in cddl/lib/drti.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27535
Build 25759: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 15 2019, 3:45 PM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptNov 15 2019, 3:45 PM

Harbormaster completed remote builds in B27535: Diff 64373.Nov 15 2019, 3:45 PM

arichardson added reviewers: sjg, brd, brooks.Nov 15 2019, 3:46 PM

LGTM

This revision is now accepted and ready to land.Nov 15 2019, 6:08 PM

Closed by commit rS354740: Fix build race in bsd.files.mk (authored by arichardson). · Explain WhyNov 15 2019, 6:34 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS354740: Fix build race in bsd.files.mk.

Herald added a subscriber: imp. · View Herald TranscriptNov 15 2019, 6:34 PM

sjg added inline comments.Nov 19 2019, 1:19 AM

head/share/mk/bsd.files.mk
119 ↗	(On Diff #64387)	I would be more inclined to use `${.ALLSRC:Ninstalldirs-*}` rather than assume order of `.ALLSRC`

arichardson mentioned this in rS355582: Use ${.ALLSRC:Ninstalldirs-*} instead of assuming order of .ALLSRC.Dec 10 2019, 12:13 PM

Revision Contents
Changeset List

Path

Size

share/

mk/

7 lines

Diff 64373

share/mk/bsd.files.mk

Loading...