Paths

Table of Contentst

Differential D21666

Let the RACK stack take IP options into account when computing the space for user data in TCP segments
ClosedPublic
Actions

Authored by tuexen on Sep 15 2019, 5:53 PM.

Tags

None

Referenced Files

	F167398179: D21666.diff
	Fri, Aug 21, 1:22 PM

	F167387519: D21666.id62129.diff
	Fri, Aug 21, 12:14 PM

	F167305908: D21666.diff
	Thu, Aug 20, 7:49 PM

	Unknown Object (File)
	Mon, Aug 17, 5:40 PM

	Unknown Object (File)
	Sat, Aug 15, 5:23 PM

	Unknown Object (File)
	Sun, Aug 9, 11:29 AM

	Unknown Object (File)
	Sun, Aug 9, 11:28 AM

	Unknown Object (File)
	Sun, Jul 26, 4:05 PM

Subscribers

Details

Reviewers

rrs
rscheff
jtl
bz

Group Reviewers

Commits

rS352673: MFC r352512:
rS352512: When the RACK stack computes the space for user data in a TCP segment,

Summary

When the RACK stack computes the space for user data in a TCP segment, it wasn't taking the IP level options into account. This patch fixes this. It also corrects a KASSERT and adds the protection code missing also from the default stack and to be added in D21665 .
Without this fix, IP level fragmentation would occur.

Test Plan

Check with the following test program that no IP level fragmentation occurs (use RACK as the default stack):

connect-with-dst-opt.c917 BDownload

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 15 2019, 5:53 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 15 2019, 5:53 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B26509: Diff 62129.Sep 15 2019, 5:53 PM

rrs accepted this revision.Sep 17 2019, 12:48 PM

This revision is now accepted and ready to land.Sep 17 2019, 12:48 PM

Closed by commit rS352512: When the RACK stack computes the space for user data in a TCP segment, (authored by tuexen). · Explain WhySep 19 2019, 10:28 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS352512: When the RACK stack computes the space for user data in a TCP segment,.

tuexen added a commit: rS352673: MFC r352512:.Sep 25 2019, 10:41 AM

tuexen mentioned this in rS353040: MFS r352673:.Oct 3 2019, 12:27 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_stacks/

35 lines

Diff 62304

head/sys/netinet/tcp_stacks/rack.c

Loading...