Page MenuHomeFreeBSD
Differential D21616

Replace MD5 by SipHash as TCP keyed hash function
ClosedPublic
Actions

Authored by tuexen on Sep 12 2019, 2:03 PM.
Tags
None
Referenced Files
F169400658: D21616.id61972.diff
Tue, Sep 1, 10:40 AM
F169383798: D21616.id61972.diff
Tue, Sep 1, 9:28 AM
F169378513: D21616.diff
Tue, Sep 1, 9:07 AM
Unknown Object (File)
Tue, Sep 1, 7:32 AM
Unknown Object (File)
Tue, Sep 1, 3:47 AM
Unknown Object (File)
Sun, Aug 30, 9:00 AM
Unknown Object (File)
Sun, Aug 30, 8:03 AM
Unknown Object (File)
Sun, Aug 30, 7:56 AM
View All Files
Subscribers
imp

Details

Reviewers
gallatin
rrs
jtl
rscheff
Group Reviewers
transport
Commits
rS352843: Replacing MD5 by SipHash improves the performance of the TCP time stamp
Summary

Replacing MD5 by SipHash improves the performance of the time stamp initialisation, which is important when the host is receiving a SYN flood.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26419

Event Timeline

tuexen created this revision.Sep 12 2019, 2:03 PM
Herald added a reviewer: transport. · View Herald TranscriptSep 12 2019, 2:03 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B26419: Diff 61972.Sep 12 2019, 2:03 PM
tuexen added a reviewer: rscheff.Sep 12 2019, 2:29 PM
gallatin accepted this revision.Sep 26 2019, 2:13 PM

I tested this, and it performed well and worked fine.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2019, 1:13 PM
Closed by commit rS352843: Replacing MD5 by SipHash improves the performance of the TCP time stamp (authored by tuexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS352843: Replacing MD5 by SipHash improves the performance of the TCP time stamp.

Revision Contents
Changeset List

PathSize
sys/
netinet/
34 lines

Diff 61972

View Options

sys/netinet/tcp_subr.c

Loading...