Page MenuHomeFreeBSD
Differential D21546

Eliminate redundant vm code with a few new convenience functions.
ClosedPublic
Actions

Authored by jeff on Sep 6 2019, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 2, 1:53 PM
Unknown Object (File)
Thu, May 29, 3:18 PM
Unknown Object (File)
Sun, May 18, 2:34 PM
Unknown Object (File)
Mon, May 12, 8:16 PM
Unknown Object (File)
May 6 2025, 6:41 AM
Unknown Object (File)
May 1 2025, 9:18 AM
Unknown Object (File)
Apr 29 2025, 3:58 PM
Unknown Object (File)
Apr 27 2025, 7:35 AM
View All 65 Files
Subscribers
delphij
emaste
imp

Details

Reviewers
alc
markj
kib
dougm
Commits
rS352176: Replace redundant code with a few new vm_page_grab facilities:
Summary

This is a combination of the below two reviews.

https://reviews.freebsd.org/D21332
https://reviews.freebsd.org/D21331

I eliminated VM_ALLOC_VALID in favor of using VM_ALLOC_NOCREAT with vm_page_grab_valid(). It simplifies things a bit and I think is less ambiguous.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26305
Build 24784: arc lint + arc unit

Event Timeline

jeff created this revision.Sep 6 2019, 12:35 PM
Herald added subscribers: emaste, delphij. · View Herald TranscriptSep 6 2019, 12:35 PM
Harbormaster completed remote builds in B26305: Diff 61723.Sep 6 2019, 12:35 PM
jeff retitled this revision from Eliminate redundant with a few new convenience functions. to Eliminate redundant vm code with a few new convenience functions..Sep 6 2019, 12:42 PM
jeff edited the summary of this revision. (Show Details)
jeff added reviewers: alc, markj, kib, dougm.
This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2019, 7:08 PM
Closed by commit rS352176: Replace redundant code with a few new vm_page_grab facilities: (authored by jeff). · Explain Why
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS352176: Replace redundant code with a few new vm_page_grab facilities:.
Herald added a subscriber: imp. · View Herald TranscriptSep 10 2019, 7:08 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
63 lines
compat/
linuxkpi/
common/
src/
26 lines
dev/
drm2/
ttm/
7 lines
20 lines
xen/
gntdev/
2 lines
privcmd/
2 lines
kern/
25 lines
vm/
21 lines
13 lines
4 lines
179 lines

Diff 61723

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_page.c

Loading...
View Options

sys/dev/drm2/ttm/ttm_bo_vm.c

Loading...
View Options

sys/dev/drm2/ttm/ttm_tt.c

Loading...
View Options

sys/dev/xen/gntdev/gntdev.c

Loading...
View Options

sys/dev/xen/privcmd/privcmd.c

Loading...
View Options

sys/kern/uipc_shm.c

Loading...
View Options

sys/vm/vm_glue.c

Loading...
View Options

sys/vm/vm_object.c

Loading...
View Options

sys/vm/vm_page.h

Loading...
View Options

sys/vm/vm_page.c

Loading...