Page MenuHomeFreeBSD
Differential D21536

nvdimm(4): Add description of NVDIMM Namespace support
ClosedPublic
Actions

Authored by scottph on Sep 5 2019, 6:37 PM.
Tags
None
Referenced Files
F150980417: D21536.id61706.diff
Sun, Apr 5, 7:06 AM
Unknown Object (File)
Sat, Apr 4, 6:13 AM
Unknown Object (File)
Sat, Apr 4, 1:50 AM
Unknown Object (File)
Fri, Apr 3, 10:27 PM
Unknown Object (File)
Thu, Apr 2, 8:35 PM
Unknown Object (File)
Wed, Mar 25, 1:15 AM
Unknown Object (File)
Tue, Mar 24, 11:44 PM
Unknown Object (File)
Tue, Mar 24, 1:54 AM
View All Files
Subscribers
bcr
imp
scottl

Details

Reviewers
kib
emaste
bcr
Group Reviewers
manpages
Commits
rS351897: nvdimm(4): Add description of NVDIMM Namespace support
Summary

Sponsored by: Intel Corporation
MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

scottph created this revision.Sep 5 2019, 6:37 PM
Herald added a reviewer: manpages. · View Herald TranscriptSep 5 2019, 6:37 PM
Herald added a subscriber: imp. · View Herald Transcript
bcr added a subscriber: bcr.Sep 5 2019, 7:06 PM

Can you run textproc/igor and "mandoc -Tlint" over your man page changes? It will report a few things like that you need a line break after a sentence stop.

kib accepted this revision.Sep 5 2019, 7:15 PM
kib added a reviewer: emaste.
kib added inline comments.
share/man/man4/nvdimm.4
90 ↗(On Diff #61699)

I think 'Additionally' is excessive there. Namespaces are part of the basic functionality.

This revision is now accepted and ready to land.Sep 5 2019, 7:15 PM
emaste added a comment.Sep 5 2019, 7:51 PM

Content seems fine, I think it's fine to commit after igor/mandoc -Tlint updates.

scottph updated this revision to Diff 61706.Sep 5 2019, 8:00 PM
This revision now requires review to proceed.Sep 5 2019, 8:00 PM
emaste accepted this revision.Sep 5 2019, 8:09 PM
This revision is now accepted and ready to land.Sep 5 2019, 8:09 PM
kib accepted this revision.Sep 5 2019, 8:16 PM
bcr accepted this revision.Sep 5 2019, 8:24 PM

OK from manpages. Thank you!

Closed by commit rS351897: nvdimm(4): Add description of NVDIMM Namespace support (authored by scottph). · Explain WhySep 5 2019, 8:52 PM
This revision was automatically updated to reflect the committed changes.
scottph marked an inline comment as done.
scottph added a commit: rS351897: nvdimm(4): Add description of NVDIMM Namespace support.

Revision Contents
Changeset List

PathSize
head/
share/
man/
man4/
16 lines

Diff 61707

View Options

head/share/man/man4/nvdimm.4

Loading...