Page MenuHomeFreeBSD
Differential D21378

Turn off -Werror for gcc 4.2.1
ClosedPublic
Actions

Authored by imp on Aug 23 2019, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 16, 2:04 AM
Unknown Object (File)
Sun, Aug 9, 9:51 AM
Unknown Object (File)
Sun, Aug 9, 9:13 AM
Unknown Object (File)
Mon, Jul 27, 2:07 PM
Unknown Object (File)
Mon, Jul 27, 11:14 AM
Unknown Object (File)
Sat, Jul 25, 1:44 PM
Unknown Object (File)
Fri, Jul 24, 3:03 PM
Unknown Object (File)
Thu, Jul 23, 2:24 AM
View All Files
Subscribers
bdrewery

Details

Reviewers
emaste
dim
jhb
pfg
Commits
rS351430: Turn off -Werror for gcc 4.2.1 for userland
rS351429: Turn off -Werror for gcc 4.2.1
Summary

As part of marching gcc 4.2.1 out of the tree, turn off -Werror on gcc 4.2.1
compiles by default. It generates too many false positives and breaks CI
for no benefit.

Discussed on: arch@

this was spurred on by the stupid const cast away DECONST patches.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26034
Build 24579: arc lint + arc unit

Event Timeline

imp created this revision.Aug 23 2019, 3:31 PM
Harbormaster completed remote builds in B26031: Diff 61162.Aug 23 2019, 3:31 PM
imp added reviewers: emaste, dim, jhb.Aug 23 2019, 3:32 PM
imp edited the summary of this revision. (Show Details)
imp added inline comments.Aug 23 2019, 3:34 PM
sys/conf/kern.pre.mk
96

here and below need to kill trailing ).

imp added inline comments.Aug 23 2019, 3:38 PM
sys/conf/kern.pre.mk
97

convention says there should be a tab here (and below) will do (from allanjude)

imp updated this revision to Diff 61163.Aug 23 2019, 3:39 PM

nits noted

Harbormaster completed remote builds in B26032: Diff 61163.Aug 23 2019, 3:39 PM
imp added a comment.Aug 23 2019, 3:43 PM

Passes MALTA kernel build.
Passes MALTA64 kernel build.
Passes powerpc GENERIC build.

imp updated this revision to Diff 61165.Aug 23 2019, 3:49 PM

add Turn off -Werror for gcc 4.2.1 for userland

Herald added a subscriber: bdrewery. · View Herald TranscriptAug 23 2019, 3:49 PM
Harbormaster completed remote builds in B26034: Diff 61165.Aug 23 2019, 3:49 PM
jhb accepted this revision.Aug 23 2019, 3:51 PM
This revision is now accepted and ready to land.Aug 23 2019, 3:51 PM
emaste accepted this revision.Aug 23 2019, 3:56 PM
pfg accepted this revision.Aug 23 2019, 4:00 PM
Closed by commit rS351429: Turn off -Werror for gcc 4.2.1 (authored by imp). · Explain WhyAug 23 2019, 4:42 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rS351429: Turn off -Werror for gcc 4.2.1.
imp added a commit: rS351430: Turn off -Werror for gcc 4.2.1 for userland.

Revision Contents
Changeset List

PathSize
share/
mk/
9 lines
sys/
conf/
6 lines
5 lines

Diff 61165

View Options

share/mk/bsd.sys.mk

Loading...
View Options

sys/conf/kern.pre.mk

Loading...
View Options

sys/conf/kmod.mk

Loading...