Turn off -Werror for gcc 4.2.1
ClosedPublic
Actions

Authored by imp on Aug 23 2019, 3:31 PM.

Details

Reviewers

emaste
dim
jhb
pfg

Commits

rS351430: Turn off -Werror for gcc 4.2.1 for userland
rS351429: Turn off -Werror for gcc 4.2.1

Summary

As part of marching gcc 4.2.1 out of the tree, turn off -Werror on gcc 4.2.1
compiles by default. It generates too many false positives and breaks CI
for no benefit.

Discussed on: arch@

this was spurred on by the stupid const cast away DECONST patches.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26032
Build 24577: arc lint + arc unit

Event Timeline

imp created this revision.Aug 23 2019, 3:31 PM

Harbormaster completed remote builds in B26031: Diff 61162.Aug 23 2019, 3:31 PM

imp added reviewers: emaste, dim, jhb.Aug 23 2019, 3:32 PM

imp edited the summary of this revision. (Show Details)

imp added inline comments.Aug 23 2019, 3:34 PM

sys/conf/kern.pre.mk
96	here and below need to kill trailing ).

imp added inline comments.Aug 23 2019, 3:38 PM

sys/conf/kern.pre.mk
97	convention says there should be a tab here (and below) will do (from allanjude)

nits noted

Harbormaster completed remote builds in B26032: Diff 61163.Aug 23 2019, 3:39 PM

Passes MALTA kernel build.
Passes MALTA64 kernel build.
Passes powerpc GENERIC build.

add Turn off -Werror for gcc 4.2.1 for userland

Herald added a subscriber: bdrewery. · View Herald TranscriptAug 23 2019, 3:49 PM

Harbormaster completed remote builds in B26034: Diff 61165.Aug 23 2019, 3:49 PM

jhb accepted this revision.Aug 23 2019, 3:51 PM

This revision is now accepted and ready to land.Aug 23 2019, 3:51 PM

emaste accepted this revision.Aug 23 2019, 3:56 PM

pfg accepted this revision.Aug 23 2019, 4:00 PM

Closed by commit rS351429: Turn off -Werror for gcc 4.2.1 (authored by imp). · Explain WhyAug 23 2019, 4:42 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS351429: Turn off -Werror for gcc 4.2.1.

imp added a commit: rS351430: Turn off -Werror for gcc 4.2.1 for userland.

Revision Contents
Changeset List

Path

Size

sys/

conf/

kern.pre.mk

6 lines

kmod.mk

5 lines

Diff 61163

View Options

sys/conf/kern.pre.mk