Page MenuHomeFreeBSD
Differential D18788

Documenting fetchReqHTTP in libfetch manual
ClosedPublic
Actions

Authored by farhan_farhan.codes on Jan 9 2019, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 1:53 PM
Unknown Object (File)
Mon, Nov 25, 8:39 PM
Unknown Object (File)
Mon, Nov 25, 5:23 AM
Unknown Object (File)
Sat, Nov 23, 5:47 PM
Unknown Object (File)
Nov 23 2024, 2:49 PM
Unknown Object (File)
Nov 23 2024, 2:47 PM
Unknown Object (File)
Nov 21 2024, 3:23 PM
Unknown Object (File)
Nov 21 2024, 3:23 PM
View All 100 Files
Subscribers
0mp
imp
markj

Details

Reviewers
kevans
des
0mp
markj
Group Reviewers
manpages
Commits
rS351573: Document fetchReqHTTP().
Summary

Adding documenting for the fetchReqHTTP function in fetch(3)/libfetch.
Also added:
A comment to lib/libfetch/http.c to be consistent with other functions.
Manual page symlink for fetchReqHTTP in Makefile

Test Plan

Review the man page for fetch(3) to ensure that the changes were correctly done.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

farhan_farhan.codes created this revision.Jan 9 2019, 7:44 AM
kevans added a reviewer: des.Jan 9 2019, 12:49 PM

Adding des; I think this looks OK, but there may be a reason it was undocumented.

farhan_farhan.codes added a comment.Jan 19 2019, 12:05 AM

Hi,
Any updates on this? It should be a pretty quick documentation update.
Thanks!

farhan_farhan.codes added a comment.Jun 10 2019, 3:23 AM

A few months old - any updates?

farhan_farhan.codes added a comment.Aug 7 2019, 6:28 AM

Any updates on this? Its been sitting here for quite a while now...

farhan_farhan.codes added a comment.Aug 20 2019, 2:07 AM

Hi @kevans, any updates on this?

markj added a subscriber: markj.Aug 20 2019, 2:21 AM
markj added inline comments.
lib/libfetch/Makefile
82

This should be sorted before fetchStat.3.

lib/libfetch/fetch.3
400

Quotes should be formatted with .Ql. So,

to the intended verb, such as
.Ql POST ,
and
.Fa body
to the content.
allanjude added a reviewer: manpages.Aug 20 2019, 3:12 AM
0mp accepted this revision.Aug 20 2019, 8:14 AM
0mp added a subscriber: 0mp.

OK from manpages assuming that the comments made by @markj will get addressed.

This revision is now accepted and ready to land.Aug 20 2019, 8:14 AM
farhan_farhan.codes updated this revision to Diff 61063.Aug 20 2019, 7:49 PM

Updated per @markj 's comments.

I should add, I also have some changes to fetch.3 in D18908 that may conflict. However, it should be easy to reconcile.

This revision now requires review to proceed.Aug 20 2019, 7:49 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 20 2019, 7:49 PM
farhan_farhan.codes marked an inline comment as done.Aug 20 2019, 7:49 PM
markj accepted this revision.Aug 21 2019, 3:12 PM
markj added inline comments.
lib/libfetch/fetch.3
406

This last fragment is duplicated.

This revision is now accepted and ready to land.Aug 21 2019, 3:12 PM
farhan_farhan.codes updated this revision to Diff 61145.Aug 23 2019, 5:55 AM

Silly mistake, removed the duplicate.

This revision now requires review to proceed.Aug 23 2019, 5:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 5:01 PM
Closed by commit rS351573: Document fetchReqHTTP(). (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS351573: Document fetchReqHTTP()..

Revision Contents
Changeset List

PathSize
lib/
libfetch/
1 line
20 lines
3 lines

Diff 61145

View Options

lib/libfetch/Makefile

Loading...
View Options

lib/libfetch/fetch.3

Loading...
View Options

lib/libfetch/http.c

Loading...