Page MenuHomeFreeBSD
Differential D21357

Move OBJT_VNODE specific code from vm_object_terminate() to vnode_destroy_vobject().
ClosedPublic
Actions

Authored by kib on Aug 21 2019, 9:29 PM.
Tags
None
Referenced Files
F137281007: D21357.id.diff
Sat, Nov 22, 12:47 AM
F137280965: D21357.id61091.diff
Sat, Nov 22, 12:47 AM
F137280894: D21357.id61095.diff
Sat, Nov 22, 12:47 AM
F137280670: D21357.id61260.diff
Sat, Nov 22, 12:45 AM
F137280628: D21357.id61094.diff
Sat, Nov 22, 12:44 AM
F137279711: D21357.diff
Sat, Nov 22, 12:39 AM
Unknown Object (File)
Thu, Nov 20, 11:56 PM
Unknown Object (File)
Thu, Nov 20, 8:14 PM
View All Files
Subscribers
imp
pho

Details

Reviewers
jeff
alc
markj
dougm
Commits
rS351478: Move OBJT_VNODE specific code from vm_object_terminate() to
Summary

Peter, could you, please, check this change ?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 25998

Event Timeline

kib created this revision.Aug 21 2019, 9:29 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 21 2019, 9:29 PM
Harbormaster completed remote builds in B25997: Diff 61091.Aug 21 2019, 9:29 PM
jeff added a comment.Aug 21 2019, 9:31 PM

In general I like this but the double setting of OBJ_DEAD does make it harder to detect things like double frees.

kib updated this revision to Diff 61094.Aug 21 2019, 9:44 PM

Untangle multiple OBJ_DEAD sets.

Harbormaster completed remote builds in B25998: Diff 61094.Aug 21 2019, 9:44 PM
jeff accepted this revision.Aug 21 2019, 9:49 PM
This revision is now accepted and ready to land.Aug 21 2019, 9:49 PM
kib updated this revision to Diff 61095.Aug 21 2019, 9:51 PM

Redo the patch back to the initial variant. Note that there is only one place that calls vm_object_terminate_dead(), so it costs nothing to set OBJ_DEAD flag there and make vm_object_terminate() to expect OBJ_DEAD is already set.

This is cleaner IMO, since both terminate_dead and terminate really not needed.

This revision now requires review to proceed.Aug 21 2019, 9:51 PM
Harbormaster completed remote builds in B25999: Diff 61095.Aug 21 2019, 9:51 PM
markj accepted this revision.Aug 21 2019, 10:14 PM
This revision is now accepted and ready to land.Aug 21 2019, 10:14 PM
kib edited the summary of this revision. (Show Details)Aug 22 2019, 8:20 AM
kib added a subscriber: pho.
alc accepted this revision.Aug 23 2019, 5:42 AM
pho added a comment.Aug 25 2019, 6:49 AM

I ran all of the stress2 tests with D21357.61095.diff on amd64. LGTM.

Closed by commit rS351478: Move OBJT_VNODE specific code from vm_object_terminate() to (authored by kib). · Explain WhyAug 25 2019, 1:26 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS351478: Move OBJT_VNODE specific code from vm_object_terminate() to.

Revision Contents
Changeset List

PathSize
sys/
vm/
2 lines
33 lines
17 lines

Diff 61094

View Options

sys/vm/vm_object.h

Loading...
View Options

sys/vm/vm_object.c

Loading...
View Options

sys/vm/vnode_pager.c

Loading...