Page MenuHomeFreeBSD

Move OBJT_VNODE specific code from vm_object_terminate() to vnode_destroy_vobject().
ClosedPublic

Authored by kib on Aug 21 2019, 9:29 PM.
Tags
None
Referenced Files
F148114877: D21357.id61091.diff
Sun, Mar 15, 9:30 PM
F148078185: D21357.id61095.diff
Sun, Mar 15, 2:50 PM
Unknown Object (File)
Sat, Mar 14, 9:50 PM
Unknown Object (File)
Fri, Mar 6, 8:24 PM
Unknown Object (File)
Fri, Mar 6, 9:45 AM
Unknown Object (File)
Thu, Mar 5, 9:42 PM
Unknown Object (File)
Jan 6 2026, 10:26 PM
Unknown Object (File)
Dec 29 2025, 7:10 PM
Subscribers

Details

Summary

Peter, could you, please, check this change ?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

In general I like this but the double setting of OBJ_DEAD does make it harder to detect things like double frees.

Untangle multiple OBJ_DEAD sets.

This revision is now accepted and ready to land.Aug 21 2019, 9:49 PM

Redo the patch back to the initial variant. Note that there is only one place that calls vm_object_terminate_dead(), so it costs nothing to set OBJ_DEAD flag there and make vm_object_terminate() to expect OBJ_DEAD is already set.

This is cleaner IMO, since both terminate_dead and terminate really not needed.

This revision now requires review to proceed.Aug 21 2019, 9:51 PM
This revision is now accepted and ready to land.Aug 21 2019, 10:14 PM
kib added a subscriber: pho.

I ran all of the stress2 tests with D21357.61095.diff on amd64. LGTM.