Page MenuHomeFreeBSD
Differential D21169

Handle concurrent pmap_kextract() and promotion/demotion on arm64
ClosedPublic
Actions

Authored by alc on Aug 6 2019, 3:15 PM.
Tags
None
Referenced Files
F170709145: D21169.id60507.diff
Sun, Sep 6, 3:37 AM
F170695720: D21169.id60507.diff
Sun, Sep 6, 1:57 AM
F170641574: D21169.id.diff
Sat, Sep 5, 6:42 PM
F170569230: D21169.id60545.diff
Sat, Sep 5, 11:07 AM
Unknown Object (File)
Sat, Sep 5, 2:33 AM
Unknown Object (File)
Sat, Sep 5, 1:32 AM
Unknown Object (File)
Sat, Sep 5, 1:24 AM
Unknown Object (File)
Fri, Sep 4, 7:58 PM
View All Files
Subscribers
andrew
emaste
imp
val_packett.cool

Details

Reviewers
andrew
markj
manu
Commits
rS350741: Ordinarily, during a superpage promotion or demotion within a pmap, the

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc created this revision.Aug 6 2019, 3:15 PM
Herald added subscribers: emaste, andrew. · View Herald TranscriptAug 6 2019, 3:15 PM
alc mentioned this in D21149: Enable superpage promotion within the kernel pmap on arm64.Aug 6 2019, 3:20 PM
alc added reviewers: andrew, markj.Aug 6 2019, 6:17 PM
andrew accepted this revision.Aug 7 2019, 10:20 AM
andrew added inline comments.
arm64/arm64/pmap.c
1134 ↗(On Diff #60507)

This else is unneeded as the if will return.

This revision is now accepted and ready to land.Aug 7 2019, 10:20 AM
alc updated this revision to Diff 60545.Aug 7 2019, 4:09 PM

Deindent most of pmap_kextract().

Revise the comment in pmap_kextract() to refer to pmap_update_entry() rather than demotion and promotion because we also use pmap_update_entry() on L3 entries in pmap_change_attr_locked().

This revision now requires review to proceed.Aug 7 2019, 4:09 PM
alc marked an inline comment as done.Aug 7 2019, 4:10 PM
markj accepted this revision.Aug 7 2019, 4:11 PM
This revision is now accepted and ready to land.Aug 7 2019, 4:11 PM
andrew accepted this revision.Aug 7 2019, 4:22 PM
Closed by commit rS350741: Ordinarily, during a superpage promotion or demotion within a pmap, the (authored by alc). · Explain WhyAug 8 2019, 6:26 AM
This revision was automatically updated to reflect the committed changes.
alc added a commit: rS350741: Ordinarily, during a superpage promotion or demotion within a pmap, the.
Herald added a reviewer: manu. · View Herald TranscriptAug 8 2019, 6:26 AM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
69 lines
include/
7 lines

Diff 60568

View Options

head/sys/arm64/arm64/pmap.c

Loading...
View Options

head/sys/arm64/include/pte.h

Loading...