Fix two mismatches between function declaration and definition.
ClosedPublic
Actions

Authored by brooks on Jul 15 2019, 10:44 PM.

Details

Reviewers

jhb
kib
cem

Commits

rP508981: MFH: r508980
rP508980: Fix two mismatches between function declaration and definition.
rS350300: MFC r350049:
rS350049: Fix two mismatches between function declaration and definition.

Summary

In both cases, function pointer arguments were inconsistently declared
and the result worked because of C's odd rules around function pointer
(de)references. With a stricter compiler these fail to compile.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25357
Build 24010: arc lint + arc unit

Event Timeline

brooks created this revision.Jul 15 2019, 10:44 PM

Harbormaster completed remote builds in B25357: Diff 59790.Jul 15 2019, 10:44 PM

While we should probably just do in amd, these are easy fixes and there's no upstream conflicts to worry about (last am-utils release in 2014 and their git server don't seem to host a repo.

I'd just drop the extra * on the other of the definition/declaration, but I don't know if we have a style(9) preference. Functionally / semantically it looks good.

This revision is now accepted and ready to land.Jul 15 2019, 10:49 PM

brooks retitled this revision from Fix two mismatches between function decleration and definition. to Fix two mismatches between function declaration and definition..Jul 16 2019, 4:02 PM

Closed by commit rS350049: Fix two mismatches between function declaration and definition. (authored by brooks). · Explain WhyJul 16 2019, 4:03 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS350049: Fix two mismatches between function declaration and definition..

Herald added a subscriber: imp. · View Herald TranscriptJul 16 2019, 4:03 PM

brooks added a commit: rS350300: MFC r350049:.Jul 24 2019, 8:18 PM

cy added a commit: rP508980: Fix two mismatches between function declaration and definition..Aug 15 2019, 2:22 AM

cy added a commit: rP508981: MFH: r508980.Aug 15 2019, 5:05 AM