In both cases, function pointer arguments were inconsistently declared
and the result worked because of C's odd rules around function pointer
(de)references. With a stricter compiler these fail to compile.
Details
Details
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 25357 Build 24010: arc lint + arc unit
Event Timeline
Comment Actions
While we should probably just do in amd, these are easy fixes and there's no upstream conflicts to worry about (last am-utils release in 2014 and their git server don't seem to host a repo.
Comment Actions
I'd just drop the extra * on the other of the definition/declaration, but I don't know if we have a style(9) preference. Functionally / semantically it looks good.