Page MenuHomeFreeBSD
Differential D20905

Don't pass error from syscallenter() to syscallret().
ClosedPublic
Actions

Authored by jhb on Jul 10 2019, 6:07 PM.
Tags
None
Referenced Files
F152759285: D20905.id.diff
Thu, Apr 16, 10:54 PM
F152725665: D20905.id.diff
Thu, Apr 16, 5:47 PM
Unknown Object (File)
Mon, Apr 13, 9:59 PM
Unknown Object (File)
Sun, Apr 12, 8:55 AM
Unknown Object (File)
Thu, Apr 9, 2:32 AM
Unknown Object (File)
Thu, Apr 9, 1:58 AM
Unknown Object (File)
Wed, Apr 8, 8:09 AM
Unknown Object (File)
Wed, Apr 8, 5:29 AM
View All 77 Files
Subscribers
andrew
bdragon
emaste
jhibbits

Details

Reviewers
kib
manu
Commits
rS350013: Don't pass error from syscallenter() to syscallret().
Summary

syscallret() doesn't use error anymore. Fix a few other places to permit
removing the return value from syscallenter() entirely.

  • Remove a duplicated assertion from arm's syscall().
  • Use td_errno for amd64_syscall_ret_flush_l1d.
Test Plan
  • compiled amd64 and i386, still need to do a full tinderbox

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25283
Build 23948: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
7 lines
ia32/
7 lines
arm/
arm/
7 lines
arm64/
arm64/
5 lines
i386/
i386/
5 lines
kern/
5 lines
mips/
mips/
6 lines
powerpc/
powerpc/
5 lines
riscv/
riscv/
5 lines
sparc64/
sparc64/
5 lines

Diff 59607

View Options

sys/amd64/amd64/trap.c

Loading...
View Options

sys/amd64/ia32/ia32_syscall.c

Loading...
View Options

sys/arm/arm/syscall.c

Loading...
View Options

sys/arm64/arm64/trap.c

Loading...
View Options

sys/i386/i386/trap.c

Loading...
View Options

sys/kern/subr_syscall.c

Loading...
View Options

sys/mips/mips/trap.c

Loading...
View Options

sys/powerpc/powerpc/trap.c

Loading...
View Options

sys/riscv/riscv/trap.c

Loading...
View Options

sys/sparc64/sparc64/trap.c

Loading...