Differential D20905

Don't pass error from syscallenter() to syscallret().
ClosedPublic
Actions

Authored by jhb on Jul 10 2019, 6:07 PM.

Details

Reviewers

kib
manu

Commits

rS350013: Don't pass error from syscallenter() to syscallret().

Summary

syscallret() doesn't use error anymore. Fix a few other places to permit
removing the return value from syscallenter() entirely.

Remove a duplicated assertion from arm's syscall().
Use td_errno for amd64_syscall_ret_flush_l1d.

Test Plan

compiled amd64 and i386, still need to do a full tinderbox

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25283
Build 23948: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 10 2019, 6:07 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 10 2019, 6:07 PM

Herald added subscribers: bdragon, jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B25283: Diff 59607.Jul 10 2019, 6:07 PM

jhb added a parent revision: D20898: Always set td_errno to the error value of a system call..Jul 10 2019, 6:07 PM

Thanks.

sys/arm/arm/syscall.c
146	Remove this blank line as well.

This revision is now accepted and ready to land.Jul 10 2019, 6:25 PM

jhb marked an inline comment as done.Jul 15 2019, 9:18 PM

jhb closed this revision.Jul 15 2019, 9:28 PM

jhb added a commit: rS350013: Don't pass error from syscallenter() to syscallret()..

Revision Contents
Changeset List

Path

Size

sys/

amd64/

trap.c

7 lines

ia32/

ia32_syscall.c

7 lines

arm/

syscall.c

7 lines

arm64/

trap.c

5 lines

i386/

trap.c

5 lines

kern/

subr_syscall.c

5 lines

mips/

trap.c

6 lines

powerpc/

trap.c

5 lines

riscv/

trap.c

5 lines

sparc64/

trap.c

5 lines

Diff 59607

View Options

sys/amd64/amd64/trap.c

View Options

sys/amd64/ia32/ia32_syscall.c

View Options

sys/arm/arm/syscall.c

View Options

sys/arm64/arm64/trap.c

View Options

sys/i386/i386/trap.c

View Options

sys/kern/subr_syscall.c

View Options

sys/mips/mips/trap.c

View Options

sys/powerpc/powerpc/trap.c

View Options

sys/riscv/riscv/trap.c

View Options

sys/sparc64/sparc64/trap.c

Don't pass error from syscallenter() to syscallret().ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 59607

sys/amd64/amd64/trap.c

sys/amd64/ia32/ia32_syscall.c

sys/arm/arm/syscall.c

sys/arm64/arm64/trap.c

sys/i386/i386/trap.c

sys/kern/subr_syscall.c

sys/mips/mips/trap.c

sys/powerpc/powerpc/trap.c

sys/riscv/riscv/trap.c

sys/sparc64/sparc64/trap.c

Don't pass error from syscallenter() to syscallret().
ClosedPublic
Actions

Revision Contents
Changeset List