Differential D20843

[PPC64] pseries llan: fix MAC address
ClosedPublic
Actions

Authored by luporl on Jul 3 2019, 4:34 PM.

Details

Reviewers

jhibbits
bdragon
nwhitehorn

Commits

rS349723: [PPC64] pseries llan: fix MAC address

Summary

There was an issue in pseries llan driver, that resulted in the first 2 bytes of the MAC address getting stripped, and the last 2 being always 0.

In most cases the network interface still worked, despite the MAC being different of what was specified to QEMU, but when some other host or DHCP server expected a specific MAC, this would fail.

This change fixes this by shifting right by 2 the local-mac-address read from device tree, if its length is 6 instead of 8, as observed in QEMU DT, that always presents a 6 bytes value for this property.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25194
Build 23876: arc lint + arc unit

Event Timeline

luporl created this revision.Jul 3 2019, 4:34 PM

Harbormaster completed remote builds in B25191: Diff 59348.Jul 3 2019, 4:34 PM

This fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237471

jhibbits added inline comments.Jul 3 2019, 7:04 PM

sys/powerpc/pseries/phyp_llan.c
173	You can simply use memmove() or bcopy() here. Doesn't really make a significant difference, though. I think gcc and clang will both degenerate this into the equivalent loop, or a more optimized form.