Differential D20795

Control implicit PROT_MAX() using proccontrol(1) and the FreeBSD note feature bit.
ClosedPublic
Actions

Authored by kib on Jun 28 2019, 6:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 28, 2:52 AM

	Unknown Object (File)
	Thu, Nov 27, 1:41 AM

	Unknown Object (File)
	Thu, Nov 20, 10:48 PM

	Unknown Object (File)
	Thu, Nov 20, 10:47 PM

	Unknown Object (File)
	Thu, Nov 20, 10:47 PM

	Unknown Object (File)
	Thu, Nov 20, 10:47 PM

	Unknown Object (File)
	Thu, Nov 20, 10:41 PM

	Unknown Object (File)
	Tue, Nov 4, 2:15 PM

Subscribers

Details

Reviewers

emaste
brooks
markj

Group Reviewers

Commits

rS349610: Add implicit PROT_MAX() knob to proccontrol(1).
rS349609: Control implicit PROT_MAX() using procctl(2) and the FreeBSD note
rS349608: Use traditional 'p' local to designate td->td_proc in kern_mmap.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 25134

Event Timeline

kib created this revision.Jun 28 2019, 6:16 PM

Herald added a reviewer: manpages. · View Herald TranscriptJun 28 2019, 6:16 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B25109: Diff 59163.Jun 28 2019, 6:16 PM

Overall looks reasonable, a few small alpha ordering nits.

sys/compat/freebsd32/freebsd32_misc.c
3338	alpha order
sys/vm/vm_mmap.c
60	can this go in alpha order, other misordered headers notwithstanding?
usr.bin/proccontrol/proccontrol.c
76	alpha order

Suggested rewording of a sentence.

lib/libc/sys/procctl.2
129	The image flag might still prevent the enablement.

kib marked 4 inline comments as done.Jun 28 2019, 7:31 PM

kib added inline comments.

sys/vm/vm_mmap.c
60	Not sure what would be the right place then. Moved before filedesc.h.

markj added inline comments.Jun 30 2019, 6:08 PM

lib/libc/sys/procctl.2
119	and .Xr mprotect 2
128	It would be nice to reference the sysctl here, "disabled system-wide by vm.imply_prot_max"
131	Should be "be disabled."
133	Extra _ between PROT and MAX.
136	"Use the system-wide ..."

Man page update and minor code rearrangement.

Harbormaster completed remote builds in B25134: Diff 59221.Jun 30 2019, 7:06 PM

markj accepted this revision.Jul 2 2019, 3:00 PM

This revision is now accepted and ready to land.Jul 2 2019, 3:00 PM

emaste accepted this revision.Jul 2 2019, 3:08 PM

brooks added inline comments.Jul 2 2019, 4:23 PM

lib/libc/sys/procctl.2
119	We don't imply PROT_MAX on mprotect at this time. One could make a case for it, but we're never tested it and it's not as clear a case IMO.
sys/sys/syscallsubr.h
178	It seems a little odd to me that this is here and not in some sys/vm/* header, but don't have a strong opinion.

Closed by commit rS349608: Use traditional 'p' local to designate td->td_proc in kern_mmap. (authored by kib). · Explain WhyJul 2 2019, 7:01 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS349608: Use traditional 'p' local to designate td->td_proc in kern_mmap..

kib added a commit: rS349609: Control implicit PROT_MAX() using procctl(2) and the FreeBSD note.Jul 2 2019, 7:07 PM

kib added a commit: rS349610: Add implicit PROT_MAX() knob to proccontrol(1)..Jul 2 2019, 7:12 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

48 lines

sys/

compat/

freebsd32/

freebsd32_misc.c

3 lines

kern/

57 lines

sys/

1 line

2 lines

7 lines

1 line

vm/

29 lines

usr.bin/

proccontrol/

3 lines

30 lines

Diff 59221

lib/libc/sys/procctl.2

Loading...

sys/compat/freebsd32/freebsd32_misc.c

Loading...

sys/kern/kern_procctl.c

Loading...

sys/sys/elf_common.h

Loading...

sys/sys/proc.h

Loading...

sys/sys/procctl.h

Loading...

sys/sys/syscallsubr.h

Loading...

sys/vm/vm_mmap.c

Loading...

usr.bin/proccontrol/proccontrol.1

Loading...

usr.bin/proccontrol/proccontrol.c

Loading...