Page MenuHomeFreeBSD
Differential D20801

Display the approximate space needed when a minidump fails due to lack of space.
ClosedPublic
Actions

Authored by np on Jun 29 2019, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 4, 1:37 AM
Unknown Object (File)
Wed, Oct 29, 9:17 AM
Unknown Object (File)
Wed, Oct 29, 9:17 AM
Unknown Object (File)
Wed, Oct 29, 9:16 AM
Unknown Object (File)
Wed, Oct 29, 8:53 AM
Unknown Object (File)
Tue, Oct 28, 9:00 PM
Unknown Object (File)
Fri, Oct 24, 6:46 PM
Unknown Object (File)
Tue, Oct 21, 6:34 PM
View All 74 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
jhb
kib
manu
Commits
rS349552: Display the approximate space needed when a minidump fails due to lack

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np created this revision.Jun 29 2019, 1:11 AM
Herald added a reviewer: manu. · View Herald TranscriptJun 29 2019, 1:11 AM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B25119: Diff 59182.Jun 29 2019, 1:11 AM
kib added inline comments.Jun 29 2019, 12:00 PM
sys/amd64/amd64/minidump_machdep.c
453 ↗(On Diff #59182)

We traditionally use %ju/cast to uintmax_t for large values.

Also, would it make sense to round instead of truncating ?

np added inline comments.Jun 29 2019, 6:47 PM
sys/amd64/amd64/minidump_machdep.c
453 ↗(On Diff #59182)

Both valid points. But minidumpsys already has a %llu printf with (long long)dumpsize >> 20 and I thought it better to stay consistent with existing code.

kib accepted this revision.Jun 29 2019, 7:19 PM

Anyway, do as you want. Printing any estimation of the size in case of failure is an improvement on its own, even if not perfect.

sys/amd64/amd64/minidump_machdep.c
345 ↗(On Diff #59182)

If you look closer, the formats usage is not consistent, one case uses %llu, another %ju. You may fix %llu case while there.

This revision is now accepted and ready to land.Jun 29 2019, 7:19 PM
Closed by commit rS349552: Display the approximate space needed when a minidump fails due to lack (authored by np). · Explain WhyJun 30 2019, 3:14 AM
This revision was automatically updated to reflect the committed changes.
np added a commit: rS349552: Display the approximate space needed when a minidump fails due to lack.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
7 lines
arm/
arm/
7 lines
arm64/
arm64/
7 lines
i386/
i386/
7 lines
mips/
mips/
7 lines
riscv/
riscv/
7 lines

Diff 59213

View Options

head/sys/amd64/amd64/minidump_machdep.c

Loading...
View Options

head/sys/arm/arm/minidump_machdep.c

Loading...
View Options

head/sys/arm64/arm64/minidump_machdep.c

Loading...
View Options

head/sys/i386/i386/minidump_machdep_base.c

Loading...
View Options

head/sys/mips/mips/minidump_machdep.c

Loading...
View Options

head/sys/riscv/riscv/minidump_machdep.c

Loading...