Page MenuHomeFreeBSD
Differential D20766

Add some missing RISC-V ELF defines
ClosedPublic
Actions

Authored by mhorne on Jun 26 2019, 1:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 10:39 PM
Unknown Object (File)
Sun, Apr 7, 4:00 AM
Unknown Object (File)
Sat, Apr 6, 1:00 AM
Unknown Object (File)
Sat, Apr 6, 1:00 AM
Unknown Object (File)
Jan 16 2024, 10:22 PM
Unknown Object (File)
Jan 13 2024, 5:11 PM
Unknown Object (File)
Dec 23 2023, 5:35 AM
Unknown Object (File)
Dec 23 2023, 12:53 AM
View All 53 Files
Subscribers
imp

Details

Reviewers
emaste
br
markj
Commits
rS349481: Add some missing RISC-V ELF defines
Summary

This adds defines for the RISC-V specific e_flags values, and some
missing static relocations.

The definitions come from the RISC-V ELF specification, found at:
https://github.com/riscv/riscv-elf-psabi-doc/blob/master/riscv-elf.md

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25061
Build 23774: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 26 2019, 1:09 AM
Harbormaster completed remote builds in B25046: Diff 59038.Jun 26 2019, 1:09 AM
mhorne updated this revision to Diff 59043.Jun 26 2019, 3:21 AM

Include a definition for EF_RISCV_FLOAT_ABI_SOFT. Although this is not defined
in the RISC-V ELF spec, this zero value serves as an easy check.

Harbormaster completed remote builds in B25050: Diff 59043.Jun 26 2019, 3:22 AM
markj added inline comments.Jun 26 2019, 4:10 PM
sys/sys/elf_common.h
373

I'm not sure it makes sense to include this one. If you wanted to test for the software ABI you'd write (e_flags & EF_RISCV_FLOAT_ABI_MASK) == 0, where the mask is 0x6.

markj added inline comments.Jun 26 2019, 4:11 PM
sys/sys/elf_common.h
373

After seeing the follow-up review, what you did here makes more sense. I'd just suggest adding a _MASK define instead of using _QUAD.

mhorne updated this revision to Diff 59064.Jun 26 2019, 4:37 PM

Add EF_RISCV_FLOAT_ABI_MASK

Harbormaster completed remote builds in B25061: Diff 59064.Jun 26 2019, 4:37 PM
markj accepted this revision.Jun 26 2019, 4:39 PM

Approved.

This revision is now accepted and ready to land.Jun 26 2019, 4:39 PM
Closed by commit rS349481: Add some missing RISC-V ELF defines (authored by mhorne). · Explain WhyJun 28 2019, 12:03 AM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rS349481: Add some missing RISC-V ELF defines.
Herald added a subscriber: imp. · View Herald TranscriptJun 28 2019, 12:03 AM
dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
20 lines

Diff 59064

View Options

sys/sys/elf_common.h

Loading...