Add some missing RISC-V ELF defines
ClosedPublic
Actions

Authored by mhorne on Jun 26 2019, 1:09 AM.

Details

Reviewers

emaste
br
markj

Commits

rS349481: Add some missing RISC-V ELF defines

Summary

This adds defines for the RISC-V specific e_flags values, and some
missing static relocations.

The definitions come from the RISC-V ELF specification, found at:
https://github.com/riscv/riscv-elf-psabi-doc/blob/master/riscv-elf.md

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25050
Build 23763: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 26 2019, 1:09 AM

Harbormaster completed remote builds in B25046: Diff 59038.Jun 26 2019, 1:09 AM

Include a definition for EF_RISCV_FLOAT_ABI_SOFT. Although this is not defined
in the RISC-V ELF spec, this zero value serves as an easy check.

Harbormaster completed remote builds in B25050: Diff 59043.Jun 26 2019, 3:22 AM

markj added inline comments.Jun 26 2019, 4:10 PM

sys/sys/elf_common.h
373	I'm not sure it makes sense to include this one. If you wanted to test for the software ABI you'd write `(e_flags & EF_RISCV_FLOAT_ABI_MASK) == 0`, where the mask is 0x6.

markj added inline comments.Jun 26 2019, 4:11 PM

sys/sys/elf_common.h
373	After seeing the follow-up review, what you did here makes more sense. I'd just suggest adding a _MASK define instead of using _QUAD.

Add EF_RISCV_FLOAT_ABI_MASK

Harbormaster completed remote builds in B25061: Diff 59064.Jun 26 2019, 4:37 PM

Approved.

This revision is now accepted and ready to land.Jun 26 2019, 4:39 PM

Closed by commit rS349481: Add some missing RISC-V ELF defines (authored by mhorne). · Explain WhyJun 28 2019, 12:03 AM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS349481: Add some missing RISC-V ELF defines.

Herald added a subscriber: imp. · View Herald TranscriptJun 28 2019, 12:03 AM

dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

Path

Size

sys/

elf_common.h

19 lines

Diff 59043

View Options

sys/sys/elf_common.h

	Show First 20 Lines • Show All 363 Lines • ▼ Show 20 Lines
	#define EF_MIPS_ARCH_64 0x60000000 /* -mips64 code */			#define EF_MIPS_ARCH_64 0x60000000 /* -mips64 code */
	#define EF_MIPS_ARCH_32R2 0x70000000 /* -mips32r2 code */			#define EF_MIPS_ARCH_32R2 0x70000000 /* -mips32r2 code */
	#define EF_MIPS_ARCH_64R2 0x80000000 /* -mips64r2 code */			#define EF_MIPS_ARCH_64R2 0x80000000 /* -mips64r2 code */

	#define EF_PPC_EMB 0x80000000			#define EF_PPC_EMB 0x80000000
	#define EF_PPC_RELOCATABLE 0x00010000			#define EF_PPC_RELOCATABLE 0x00010000
	#define EF_PPC_RELOCATABLE_LIB 0x00008000			#define EF_PPC_RELOCATABLE_LIB 0x00008000

				#define EF_RISCV_RVC 0x00000001
				#define EF_RISCV_FLOAT_ABI_SOFT 0x00000000
				markjUnsubmitted Not Done Inline Actions I'm not sure it makes sense to include this one. If you wanted to test for the software ABI you'd write `(e_flags & EF_RISCV_FLOAT_ABI_MASK) == 0`, where the mask is 0x6. markj: I'm not sure it makes sense to include this one. If you wanted to test for the software ABI…
				markjUnsubmitted Not Done Inline Actions After seeing the follow-up review, what you did here makes more sense. I'd just suggest adding a _MASK define instead of using _QUAD. markj: After seeing the follow-up review, what you did here makes more sense. I'd just suggest adding…
				#define EF_RISCV_FLOAT_ABI_SINGLE 0x000002
				#define EF_RISCV_FLOAT_ABI_DOUBLE 0x000004
				#define EF_RISCV_FLOAT_ABI_QUAD 0x00000006
				#define EF_RISCV_RVE 0x00000008
				#define EF_RISCV_TSO 0x00000010

	#define EF_SPARC_EXT_MASK 0x00ffff00			#define EF_SPARC_EXT_MASK 0x00ffff00
	#define EF_SPARC_32PLUS 0x00000100			#define EF_SPARC_32PLUS 0x00000100
	#define EF_SPARC_SUN_US1 0x00000200			#define EF_SPARC_SUN_US1 0x00000200
	#define EF_SPARC_HAL_R1 0x00000200			#define EF_SPARC_HAL_R1 0x00000200
	#define EF_SPARC_SUN_US3 0x00000800			#define EF_SPARC_SUN_US3 0x00000800

	#define EF_SPARCV9_MM 0x00000003			#define EF_SPARCV9_MM 0x00000003
	#define EF_SPARCV9_TSO 0x00000000			#define EF_SPARCV9_TSO 0x00000000
	▲ Show 20 Lines • Show All 925 Lines • ▼ Show 20 Lines
	#define R_RISCV_SUB16 38			#define R_RISCV_SUB16 38
	#define R_RISCV_SUB32 39			#define R_RISCV_SUB32 39
	#define R_RISCV_SUB64 40			#define R_RISCV_SUB64 40
	#define R_RISCV_GNU_VTINHERIT 41			#define R_RISCV_GNU_VTINHERIT 41
	#define R_RISCV_GNU_VTENTRY 42			#define R_RISCV_GNU_VTENTRY 42
	#define R_RISCV_ALIGN 43			#define R_RISCV_ALIGN 43
	#define R_RISCV_RVC_BRANCH 44			#define R_RISCV_RVC_BRANCH 44
	#define R_RISCV_RVC_JUMP 45			#define R_RISCV_RVC_JUMP 45
				#define R_RISCV_RVC_LUI 46
				#define R_RISCV_GPREL_I 47
				#define R_RISCV_GPREL_S 48
				#define R_RISCV_TPREL_I 49
				#define R_RISCV_TPREL_S 50
				#define R_RISCV_RELAX 51
				#define R_RISCV_SUB6 52
				#define R_RISCV_SET6 53
				#define R_RISCV_SET8 54
				#define R_RISCV_SET16 55
				#define R_RISCV_SET32 56

	#define R_SPARC_NONE 0			#define R_SPARC_NONE 0
	#define R_SPARC_8 1			#define R_SPARC_8 1
	#define R_SPARC_16 2			#define R_SPARC_16 2
	#define R_SPARC_32 3			#define R_SPARC_32 3
	#define R_SPARC_DISP8 4			#define R_SPARC_DISP8 4
	#define R_SPARC_DISP16 5			#define R_SPARC_DISP16 5
	#define R_SPARC_DISP32 6			#define R_SPARC_DISP32 6
	▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

Add some missing RISC-V ELF definesClosedPublicActions