Page MenuHomeFreeBSD
Differential D20695

Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK
ClosedPublic
Actions

Authored by khng on Jun 19 2019, 8:04 AM.
Tags
None
Referenced Files
F156860967: D20695.id59147.diff
Sat, May 16, 11:10 PM
F156860956: D20695.id59195.diff
Sat, May 16, 11:10 PM
F156860954: D20695.id58785.diff
Sat, May 16, 11:10 PM
F156860920: D20695.id58784.diff
Sat, May 16, 11:10 PM
F156859807: D20695.diff
Sat, May 16, 11:01 PM
Unknown Object (File)
Thu, May 7, 3:16 PM
Unknown Object (File)
Thu, May 7, 2:10 PM
Unknown Object (File)
Thu, May 7, 11:02 AM
View All Files
Subscribers
imp
lwhsu

Details

Reviewers
emaste
mckusick
Group Reviewers
manpages
Commits
rS350165: MFC r349543
rS349543: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK
Summary

By reading the implementation of vnode_pager_putpages_ioflags() and
vnode_pager_generic_putpages(), if VM_PAGER_CLUSTER_OK is not set write
may be performed asynchronously.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24931
Build 23656: arc lint + arc unit

Event Timeline

khng created this revision.Jun 19 2019, 8:04 AM
Harbormaster completed remote builds in B24930: Diff 58784.Jun 19 2019, 8:04 AM
khng updated this revision to Diff 58785.Jun 19 2019, 8:09 AM

Fix commit message

Harbormaster completed remote builds in B24931: Diff 58785.Jun 19 2019, 8:09 AM
lwhsu added reviewers: emaste, mckusick.Jun 26 2019, 5:02 PM
mckusick requested changes to this revision.Jun 27 2019, 9:09 PM

Doing asynchronous writes prevents clustering. The correct fix is to say:

If
.Dv VM_PAGER_CLUSTER_OK
is set, writes may be delayed so that related writes
can be coalesced for efficiency, e.g.,
This revision now requires changes to proceed.Jun 27 2019, 9:09 PM
khng updated this revision to Diff 59147.Jun 28 2019, 4:57 AM
  • Updated according to @mckusick 's suggestion
Harbormaster completed remote builds in B25102: Diff 59147.Jun 28 2019, 4:57 AM
mckusick accepted this revision.Jun 29 2019, 2:49 AM

Looks good to go.

This revision is now accepted and ready to land.Jun 29 2019, 2:49 AM
lwhsu added a subscriber: lwhsu.Jun 29 2019, 12:27 PM

I'll take care of this and also bump the .Dd field.

Closed by commit rS349543: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK (authored by lwhsu). · Explain WhyJun 29 2019, 2:56 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rS349543: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK.
Herald added a subscriber: imp. · View Herald TranscriptJun 29 2019, 2:56 PM
lwhsu added a commit: rS350165: MFC r349543.Jul 20 2019, 8:40 AM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
2 lines

Diff 58785

View Options

share/man/man9/VOP_GETPAGES.9

Loading...