Page MenuHomeFreeBSD

Linuxulator: complete LOCAL_PEERCRED support.
ClosedPublic

Authored by dchagin on May 26 2019, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 10:42 AM
Unknown Object (File)
Mar 2 2024, 4:08 PM
Unknown Object (File)
Jan 13 2024, 8:19 AM
Unknown Object (File)
Jan 10 2024, 5:18 AM
Unknown Object (File)
Jan 10 2024, 5:18 AM
Unknown Object (File)
Jan 10 2024, 5:18 AM
Unknown Object (File)
Jan 10 2024, 5:18 AM
Unknown Object (File)
Jan 2 2024, 12:33 PM
Subscribers

Details

Summary

Cache pid of the remote process in the struct xucred. Do not bump XUCRED_VERSION as struct layout is not changed.

PR: 215202

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Also cache client process pid

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

This revision is now accepted and ready to land.May 27 2019, 1:07 PM
In D20415#440959, @tijl wrote:

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

sure

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

my variant is better for static struct xucred initialization
thanks

This revision was automatically updated to reflect the committed changes.