Page MenuHomeFreeBSD
Differential D20415

Linuxulator: complete LOCAL_PEERCRED support.
ClosedPublic
Actions

Authored by dchagin on May 26 2019, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 15, 1:02 PM
Unknown Object (File)
Fri, May 8, 1:42 PM
Unknown Object (File)
Sun, May 3, 6:37 AM
Unknown Object (File)
Fri, May 1, 4:50 AM
Unknown Object (File)
Thu, Apr 30, 9:39 PM
Unknown Object (File)
Mon, Apr 27, 10:45 PM
Unknown Object (File)
Sat, Apr 25, 12:15 PM
Unknown Object (File)
Fri, Apr 24, 5:03 AM
View All Files
Subscribers
imp

Details

Reviewers
tijl
Group Reviewers
Linux Emulation
network
manpages
Commits
rG925f44f33862: Complete LOCAL_PEERCRED support. Cache pid of the remote process in the
rS348419: Complete LOCAL_PEERCRED support. Cache pid of the remote process in the
Summary

Cache pid of the remote process in the struct xucred. Do not bump XUCRED_VERSION as struct layout is not changed.

PR: 215202

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dchagin created this revision.May 26 2019, 7:06 PM
dchagin updated this revision to Diff 57920.May 26 2019, 8:50 PM

Also cache client process pid

dchagin added a reviewer: tijl.May 27 2019, 10:46 AM
tijl accepted this revision.May 27 2019, 1:07 PM

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

This revision is now accepted and ready to land.May 27 2019, 1:07 PM
dchagin added a comment.May 27 2019, 2:51 PM
In D20415#440959, @tijl wrote:

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

sure

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

my variant is better for static struct xucred initialization
thanks

Closed by commit rS348419: Complete LOCAL_PEERCRED support. Cache pid of the remote process in the (authored by dchagin). · Explain WhyMay 30 2019, 2:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: manpages. · View Herald TranscriptMay 30 2019, 2:24 PM
Herald added a subscriber: imp. · View Herald Transcript
dchagin added a commit: rG925f44f33862: Complete LOCAL_PEERCRED support. Cache pid of the remote process in the.Mar 21 2021, 5:35 AM

Revision Contents
Changeset List

PathSize
crypto/
heimdal/
lib/
ipc/
2 lines
share/
man/
man4/
1 line
sys/
compat/
linux/
5 lines
kern/
8 lines
8 lines
sys/
7 lines
usr.sbin/
mountd/
2 lines

Diff 57920

View Options

crypto/heimdal/lib/ipc/server.c

Loading...
View Options

share/man/man4/unix.4

Loading...
View Options

sys/compat/linux/linux_socket.c

Loading...
View Options

sys/kern/kern_prot.c

Loading...
View Options

sys/kern/uipc_usrreq.c

Loading...
View Options

sys/sys/ucred.h

Loading...
View Options

usr.sbin/mountd/mountd.c

Loading...