Page MenuHomeFreeBSD

Linuxulator: complete LOCAL_PEERCRED support.
ClosedPublic

Authored by dchagin on May 26 2019, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 2:15 AM
Unknown Object (File)
Tue, Aug 11, 11:34 PM
Unknown Object (File)
Sun, Aug 9, 10:20 AM
Unknown Object (File)
Sat, Aug 8, 11:02 PM
Unknown Object (File)
Sat, Aug 8, 6:08 PM
Unknown Object (File)
Sat, Aug 8, 3:56 PM
Unknown Object (File)
Sat, Aug 8, 1:13 PM
Unknown Object (File)
Sat, Aug 8, 9:54 AM
Subscribers

Details

Summary

Cache pid of the remote process in the struct xucred. Do not bump XUCRED_VERSION as struct layout is not changed.

PR: 215202

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Also cache client process pid

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

This revision is now accepted and ready to land.May 27 2019, 1:07 PM
In D20415#440959, @tijl wrote:

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

sure

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

my variant is better for static struct xucred initialization
thanks

This revision was automatically updated to reflect the committed changes.