Page MenuHomeFreeBSD

Linuxulator: complete LOCAL_PEERCRED support.
ClosedPublic

Authored by dchagin on May 26 2019, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 30 2022, 9:03 AM
Unknown Object (File)
Dec 25 2022, 11:46 PM
Unknown Object (File)
Dec 23 2022, 2:25 AM
Unknown Object (File)
Dec 18 2022, 7:10 AM
Unknown Object (File)
Dec 10 2022, 2:35 PM
Subscribers

Details

Summary

Cache pid of the remote process in the struct xucred. Do not bump XUCRED_VERSION as struct layout is not changed.

PR: 215202

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Also cache client process pid

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

This revision is now accepted and ready to land.May 27 2019, 1:07 PM
In D20415#440959, @tijl wrote:

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

sure

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

my variant is better for static struct xucred initialization
thanks

This revision was automatically updated to reflect the committed changes.