Differential D20383

[PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2)
ClosedPublic
Actions

Authored by alfredo on May 23 2019, 4:19 PM.

Details

Reviewers

dim
jhibbits
luporl

Commits

rS356112: [PowerPC64] Starting from FreeBSD 13.0, default to ELFv2 ABI

Summary

Warning: to be commited on "flag day"

This changes LLVM default powerpc64 ABI to ELFv2, if target OS is FreeBSD >= 13.0

This patch should be sent to upstream after flag day.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24440
Build 23250: arc lint + arc unit

Event Timeline

alfredo created this revision.May 23 2019, 4:19 PM

Harbormaster completed remote builds in B24440: Diff 57781.May 23 2019, 4:19 PM

alfredo planned changes to this revision.May 23 2019, 4:20 PM

alfredo added parent revisions: D20378: [PowerPC64] LLVM as default toolchain for PowerPC and PowerPC64, D20375: [PowerPC64] ports/devel/llvm80 - backport of LLVM 9 fixes in preparation for building FreeBSD/PowerPC64, D20337: [PowerPC64] backport of LLVM fixes in preparation for building FreeBSD/PowerPC64, D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

Of course this will need to go upstream as well.

In D20383#439643, @emaste wrote:

Of course this will need to go upstream as well.

Yes, I'm planning to send it to upstream (9.x) as well file backport to 8.x request release after flag day, or at least when plan is officially announced.
What do you and @jhibbits think about it?

The change itself LGTM.

From a previous discussion these days, it seems the consensus was to propose it to LLVM upstream some time after FreeBSD itself commits the ELFv2 changes.
As this changes a previous default, I'm not sure if this change is eligible for backporting, but LLVM community knows better about it.

linimon added a subscriber: linimon.Jun 12 2019, 12:34 AM

Patch updated as base LLVM switched from version 8 to 9

Harbormaster completed remote builds in B26961: Diff 63092.Oct 9 2019, 7:29 PM

Marking as Plan Changes again to avoid accidental commit before flag day

alfredo edited the summary of this revision. (Show Details)Nov 11 2019, 6:42 PM

alfredo added a reviewer: PowerPC.Dec 3 2019, 9:59 PM

alfredo removed a reviewer: PowerPC.Dec 3 2019, 10:02 PM

alfredo added a project: PowerPC.

alfredo added a subscriber: PowerPC.

alfredo removed a subscriber: PowerPC.

Back to review as no changes planned

jhibbits accepted this revision.Dec 23 2019, 10:34 PM