Page MenuHomeFreeBSD

Prevent users from building obviously defective Linuxulator modules.
ClosedPublic

Authored by dchagin on May 7 2019, 8:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 9:16 AM
Unknown Object (File)
Feb 19 2024, 9:16 AM
Unknown Object (File)
Dec 28 2023, 9:03 PM
Unknown Object (File)
Dec 20 2023, 12:18 AM
Unknown Object (File)
Dec 13 2023, 4:11 PM
Unknown Object (File)
Dec 7 2023, 4:36 PM
Unknown Object (File)
Oct 24 2023, 4:56 AM
Unknown Object (File)
Aug 15 2023, 12:38 PM

Details

Summary

Linuxulator depends on a fundamental kernel settings such as SMP. Many
of them listed in opt_global.h which is not generated while building
modules outside of a kernel and such modules never match real cofigured
kernel.

So, we should prevent our users from building obviously defective modules.

Therefore, I propose to remove the root cause of the building of modules
outside of a kernel - the possibility of building modules with DEBUG or KTR
flags. And remove all of DEBUG printfs as it is incomplete and in threaded
programms not informative, also a half of system call does not have DEBUG
printf. For debuging Linux programms we have dtrace, ktr and ktrace ability.

PR: 222861

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Have you considered splitting it into two: one for getting rid of DEBUG, and one for preventing out of tree builds? The former looks fine, but I don’t understand the build system well enough wrt the latter.

split to get rid of DEBUG and warn

The title and description don't match the patch, but apart from that - looks good!

This revision is now accepted and ready to land.May 7 2019, 4:46 PM
This revision was automatically updated to reflect the committed changes.