Page MenuHomeFreeBSD

Prevent users from building obviously defective Linuxulator modules.
ClosedPublic

Authored by dchagin on May 7 2019, 8:58 AM.
Tags
None
Referenced Files
F136905510: D20178.id57121.diff
Thu, Nov 20, 2:06 PM
F136905374: D20178.id57119.diff
Thu, Nov 20, 2:05 PM
F136905257: D20178.id57369.diff
Thu, Nov 20, 2:04 PM
F136905157: D20178.id57124.diff
Thu, Nov 20, 2:03 PM
F136905105: D20178.id.diff
Thu, Nov 20, 2:02 PM
F136904293: D20178.diff
Thu, Nov 20, 1:54 PM
Unknown Object (File)
Mon, Nov 10, 8:26 AM
Unknown Object (File)
Thu, Nov 6, 3:47 PM

Details

Summary

Linuxulator depends on a fundamental kernel settings such as SMP. Many
of them listed in opt_global.h which is not generated while building
modules outside of a kernel and such modules never match real cofigured
kernel.

So, we should prevent our users from building obviously defective modules.

Therefore, I propose to remove the root cause of the building of modules
outside of a kernel - the possibility of building modules with DEBUG or KTR
flags. And remove all of DEBUG printfs as it is incomplete and in threaded
programms not informative, also a half of system call does not have DEBUG
printf. For debuging Linux programms we have dtrace, ktr and ktrace ability.

PR: 222861

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 24128

Event Timeline

Have you considered splitting it into two: one for getting rid of DEBUG, and one for preventing out of tree builds? The former looks fine, but I don’t understand the build system well enough wrt the latter.

split to get rid of DEBUG and warn

The title and description don't match the patch, but apart from that - looks good!

This revision is now accepted and ready to land.May 7 2019, 4:46 PM
This revision was automatically updated to reflect the committed changes.