kernel"
ClosedPublic
Actions

Authored by alfredo on Mar 20 2019, 2:06 PM.

Details

Reviewers

jhibbits
emaste
kevans

Commits

rS345330: loader: fix loading of kernels with . in path

Summary

function fake_modname is prepared to read a full path to a file and retrieve its name, without and extension (".").
As example, in a path like "boot/kernel.elfv2", the substring "kernel" is extracted.

However, in paths like "boot/test.elfv2/kernel", the dot (".") is being misidentified, causes incorrect string length being calculated. It should look for a "dot" only in the last part of the file name, after the last slash character.

Note: the kernel used in this test doesn't contain any valid module, so it falls in " if (modcnt == 0)" in "__elfN(parse_modmetadata)" functions, causing fake_modname being called.

Test Plan

fix verified in QEMU VM (slof loader)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23211
Build 22254: arc lint + arc unit

Event Timeline

alfredo created this revision.Mar 20 2019, 2:06 PM

Harbormaster completed remote builds in B23211: Diff 55283.Mar 20 2019, 2:06 PM

alfredo added reviewers: jhibbits, emaste.Mar 20 2019, 2:10 PM

alfredo added subscribers: bdragon, luporl, leonardo.bianconi_eldorado.org.br, alexandre.osorio_eldorado.org.br.

emaste added subscribers: kevans, imp.Mar 20 2019, 2:20 PM

emaste added inline comments.Mar 20 2019, 2:23 PM

stand/common/load_elf.c
873	should this be `ep == sp` now? I'm not sure what exactly the intent of this check is though.

alfredo edited the summary of this revision. (Show Details)Mar 20 2019, 2:27 PM

kevans added inline comments.Mar 20 2019, 2:33 PM

stand/common/load_elf.c
873	Right, this is supposed to be weeding out boot/kernel.elfv2/.elf type stuff where there's no 'name' component. name is the beginning of string, still, and wrong in any case where there's a path separator.
878	This could be changed to s/name/sp/, but it's effectively the same - perhaps just as little more consistent with the other branch.

addresses comments from reviewers and also translates paths such as "boot/kernel/", /boot/kernel/.", ".", "/.", "/.elf", ".elf" as: "bad" (invalid_name variable)

Harbormaster completed remote builds in B23215: Diff 55287.Mar 20 2019, 4:14 PM

kevans accepted this revision.Mar 20 2019, 4:16 PM

This revision is now accepted and ready to land.Mar 20 2019, 4:16 PM

alfredo marked 3 inline comments as done.Mar 20 2019, 4:17 PM

Closed by commit rS345330: loader: fix loading of kernels with . in path (authored by emaste). · Explain WhyMar 20 2019, 4:25 PM

This revision was automatically updated to reflect the committed changes.