Page MenuHomeFreeBSD
Differential D19579

Fix bhyve's NVMe Identify Namespace data
ClosedPublic
Actions

Authored by chuck on Mar 14 2019, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 9:01 PM
Unknown Object (File)
Feb 22 2025, 9:36 AM
Unknown Object (File)
Feb 22 2025, 9:33 AM
Unknown Object (File)
Feb 21 2025, 7:19 PM
Unknown Object (File)
Feb 8 2025, 8:17 AM
Unknown Object (File)
Feb 3 2025, 12:40 AM
Unknown Object (File)
Jan 29 2025, 11:47 AM
Unknown Object (File)
Jan 22 2025, 6:41 AM
View All 75 Files
Subscribers
imp
rgrimes

Details

Reviewers
imp
ken
araujo
jhb
rgrimes
Group Reviewers
bhyve
Commits
rS345170: Fix bhyve's NVMe Identify Namespace data
Summary

The NVMe Identify Namespace data structure's Number of LBA Formats
(NLBAF) field is a 0's based value (i.e. 0x0 means 1). Since the
emulation only supports a single format, set NLBAF to 0x0, not 1.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 23080

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
2 lines

Diff 55049

View Options

usr.sbin/bhyve/pci_nvme.c

Show First 20 Lines • Show All 225 Lines • ▼ Show 20 Lines /* Native ABI */
.args = { { Atfd, 0 }, { Name, 1 }, { Octal, 2 }, { Atflags, 3 } } }, .args = { { Atfd, 0 }, { Name, 1 }, { Octal, 2 }, { Atflags, 3 } } },
{ .name = "fchown", .ret_type = 1, .nargs = 3, { .name = "fchown", .ret_type = 1, .nargs = 3,
.args = { { Int, 0 }, { Int, 1 }, { Int, 2 } } }, .args = { { Int, 0 }, { Int, 1 }, { Int, 2 } } },
{ .name = "fchownat", .ret_type = 1, .nargs = 5, { .name = "fchownat", .ret_type = 1, .nargs = 5,
.args = { { Atfd, 0 }, { Name, 1 }, { Int, 2 }, { Int, 3 }, .args = { { Atfd, 0 }, { Name, 1 }, { Int, 2 }, { Int, 3 },
{ Atflags, 4 } } }, { Atflags, 4 } } },
{ .name = "fcntl", .ret_type = 1, .nargs = 3, { .name = "fcntl", .ret_type = 1, .nargs = 3,
.args = { { Int, 0 }, { Fcntl, 1 }, { Fcntlflag, 2 } } }, .args = { { Int, 0 }, { Fcntl, 1 }, { Fcntlflag, 2 } } },
{ .name = "fdatasync", .ret_type = 1, .nargs = 1,
.args = { { Int, 0 } } },
{ .name = "flock", .ret_type = 1, .nargs = 2, { .name = "flock", .ret_type = 1, .nargs = 2,
.args = { { Int, 0 }, { Flockop, 1 } } }, .args = { { Int, 0 }, { Flockop, 1 } } },
{ .name = "fstat", .ret_type = 1, .nargs = 2, { .name = "fstat", .ret_type = 1, .nargs = 2,
.args = { { Int, 0 }, { Stat | OUT, 1 } } }, .args = { { Int, 0 }, { Stat | OUT, 1 } } },
{ .name = "fstatat", .ret_type = 1, .nargs = 4, { .name = "fstatat", .ret_type = 1, .nargs = 4,
.args = { { Atfd, 0 }, { Name | IN, 1 }, { Stat | OUT, 2 }, .args = { { Atfd, 0 }, { Name | IN, 1 }, { Stat | OUT, 2 },
{ Atflags, 3 } } }, { Atflags, 3 } } },
{ .name = "fstatfs", .ret_type = 1, .nargs = 2, { .name = "fstatfs", .ret_type = 1, .nargs = 2,
.args = { { Int, 0 }, { StatFs | OUT, 1 } } }, .args = { { Int, 0 }, { StatFs | OUT, 1 } } },
{ .name = "fsync", .ret_type = 1, .nargs = 1,
.args = { { Int, 0 } } },
{ .name = "ftruncate", .ret_type = 1, .nargs = 2, { .name = "ftruncate", .ret_type = 1, .nargs = 2,
.args = { { Int | IN, 0 }, { QuadHex | IN, 1 } } }, .args = { { Int | IN, 0 }, { QuadHex | IN, 1 } } },
{ .name = "futimens", .ret_type = 1, .nargs = 2, { .name = "futimens", .ret_type = 1, .nargs = 2,
.args = { { Int, 0 }, { Timespec2 | IN, 1 } } }, .args = { { Int, 0 }, { Timespec2 | IN, 1 } } },
{ .name = "futimes", .ret_type = 1, .nargs = 2, { .name = "futimes", .ret_type = 1, .nargs = 2,
.args = { { Int, 0 }, { Timeval2 | IN, 1 } } }, .args = { { Int, 0 }, { Timeval2 | IN, 1 } } },
{ .name = "futimesat", .ret_type = 1, .nargs = 3, { .name = "futimesat", .ret_type = 1, .nargs = 3,
.args = { { Atfd, 0 }, { Name | IN, 1 }, { Timeval2 | IN, 2 } } }, .args = { { Atfd, 0 }, { Name | IN, 1 }, { Timeval2 | IN, 2 } } },
▲ Show 20 Lines • Show All 2,472 Lines • Show Last 20 Lines