Page MenuHomeFreeBSD
Differential D19552

Integrate cddl/usr.sbin/zfds/tests into the FreeBSD test suite
ClosedPublic
Actions

Authored by ngie on Mar 12 2019, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 9:01 AM
Unknown Object (File)
Fri, Dec 20, 6:30 AM
Unknown Object (File)
Sun, Dec 8, 1:08 PM
Unknown Object (File)
Sun, Dec 8, 1:08 PM
Unknown Object (File)
Sun, Dec 8, 1:08 PM
Unknown Object (File)
Sun, Dec 8, 1:08 PM
Unknown Object (File)
Fri, Dec 6, 5:00 PM
Unknown Object (File)
Mon, Nov 25, 8:33 AM
View All Files
Subscribers
imp
lwhsu

Details

Reviewers
asomers
emaste
jtl
Commits
rS345205: Integrate cddl/usr.sbin/zfds/tests into the FreeBSD test suite
Summary

This change integrates the unit tests for zfsd into the test suite using the
integration method described in D19551.

This change removes the LOCALBASE includes added for the port version of
googlemock/googletest, as well as unnecessary LIBADD/DPADD and CXXFLAGS
defines, which are included in the GTEST_CXXFLAGS variable, as part of
D19551.

Test Plan
$ kyua test -k /usr/tests/cddl/usr.sbin/zfsd/Kyuafile
zfsd_unittest:main  ->  passed  [0.024s]

Results file id is usr_tests_cddl_usr.sbin_zfsd.20190312-000329-993750
Results saved to /home/ngie/.kyua/store/results.usr_tests_cddl_usr.sbin_zfsd.20190312-000329-993750.db

1/1 passed (0 failed)

The full results from Kyua can be found
here.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23025
Build 22097: arc lint + arc unit

Event Timeline

ngie created this revision.Mar 12 2019, 12:10 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 12 2019, 12:10 AM
Harbormaster completed remote builds in B23022: Diff 54951.Mar 12 2019, 12:10 AM
ngie edited the summary of this revision. (Show Details)Mar 12 2019, 12:11 AM
ngie edited the summary of this revision. (Show Details)
ngie updated this revision to Diff 54956.Mar 12 2019, 2:49 AM

Fix a build break with mips*/powerpc* as they lack C++11 capable compilers and
would fail to build the zfsd tests with g++ 4.2.1.

Harbormaster completed remote builds in B23025: Diff 54956.Mar 12 2019, 2:49 AM
asomers accepted this revision.Mar 12 2019, 2:59 PM
This revision is now accepted and ready to land.Mar 12 2019, 2:59 PM
emaste added a comment.Mar 12 2019, 3:18 PM

Mentor approved

Closed by commit rS345205: Integrate cddl/usr.sbin/zfds/tests into the FreeBSD test suite (authored by ngie). · Explain WhyMar 15 2019, 9:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cddl/
usr.sbin/
zfsd/
9 lines
5 lines
tests/
28 lines

Diff 54956

View Options

cddl/usr.sbin/zfsd/Makefile

Loading...
View Options

cddl/usr.sbin/zfsd/Makefile.common

Loading...
View Options

cddl/usr.sbin/zfsd/tests/Makefile

Loading...