Page MenuHomeFreeBSD

Integrate cddl/usr.sbin/zfds/tests into the FreeBSD test suite
ClosedPublic

Authored by ngie on Mar 12 2019, 12:10 AM.

Details

Summary

This change integrates the unit tests for zfsd into the test suite using the
integration method described in D19551.

This change removes the LOCALBASE includes added for the port version of
googlemock/googletest, as well as unnecessary LIBADD/DPADD and CXXFLAGS
defines, which are included in the GTEST_CXXFLAGS variable, as part of
D19551.

Test Plan
$ kyua test -k /usr/tests/cddl/usr.sbin/zfsd/Kyuafile
zfsd_unittest:main  ->  passed  [0.024s]

Results file id is usr_tests_cddl_usr.sbin_zfsd.20190312-000329-993750
Results saved to /home/ngie/.kyua/store/results.usr_tests_cddl_usr.sbin_zfsd.20190312-000329-993750.db

1/1 passed (0 failed)

The full results from Kyua can be found
here.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 23022
Build 22094: arc lint + arc unit

Event Timeline

ngie created this revision.Mar 12 2019, 12:10 AM
ngie edited the summary of this revision. (Show Details)Mar 12 2019, 12:11 AM
ngie edited the summary of this revision. (Show Details)
ngie updated this revision to Diff 54956.Mar 12 2019, 2:49 AM

Fix a build break with mips*/powerpc* as they lack C++11 capable compilers and
would fail to build the zfsd tests with g++ 4.2.1.

asomers accepted this revision.Mar 12 2019, 2:59 PM
This revision is now accepted and ready to land.Mar 12 2019, 2:59 PM

Mentor approved

This revision was automatically updated to reflect the committed changes.