Page MenuHomeFreeBSD
Differential D15090

HWPMC tracing support (4) -- ARM Coresight
Needs ReviewPublic
Actions

Authored by br on Apr 16 2018, 1:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 9:41 PM
Unknown Object (File)
Mon, Apr 14, 10:52 AM
Unknown Object (File)
Sun, Apr 13, 11:45 AM
Unknown Object (File)
Sat, Apr 12, 2:50 AM
Unknown Object (File)
Fri, Apr 4, 2:09 AM
Unknown Object (File)
Thu, Apr 3, 8:43 AM
Unknown Object (File)
Sun, Mar 30, 1:09 AM
Unknown Object (File)
Sat, Mar 29, 6:50 PM
View All Files
Subscribers
andrew
emaste

Details

Reviewers
kib
markj
manu

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br created this revision.Apr 16 2018, 1:30 PM
Herald added subscribers: emaste, andrew. · View Herald TranscriptApr 16 2018, 1:30 PM
br added reviewers: emaste, markj.Apr 16 2018, 1:35 PM
br added a parent revision: D12875: HWPMC tracing support (1) -- main.
br updated this revision to Diff 41625.Apr 18 2018, 3:41 PM

use osd(9)

br updated this revision to Diff 41691.Apr 20 2018, 2:42 PM

release object reference obtained by osd(9)

br updated this revision to Diff 42984.May 25 2018, 3:15 PM

Regenerate patch

Herald added a reviewer: manu. · View Herald TranscriptMay 25 2018, 3:15 PM
br updated this revision to Diff 43134.May 30 2018, 1:24 PM

merge changes from upstream

br updated this revision to Diff 43244.Jun 1 2018, 5:02 PM

regenerate

br updated this revision to Diff 46200.Aug 2 2018, 6:00 PM
br removed reviewers: emaste, manu.

regenerate

Herald added a reviewer: manu. · View Herald TranscriptAug 2 2018, 6:00 PM
br removed a reviewer: manu.Aug 2 2018, 6:00 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 2 2018, 6:00 PM
br updated this revision to Diff 52221.Dec 21 2018, 1:19 PM

regenerate

br updated this revision to Diff 53062.Jan 21 2019, 5:59 PM

fix style issues (wrap long lines)

br updated this revision to Diff 53159.Jan 24 2019, 5:58 PM

coresight_allocate() and coresight_release() calls added

br updated this revision to Diff 62993.Oct 7 2019, 4:16 PM

Regenerate patch.

Revision Contents
Changeset List

PathSize
sys/
arm64/
include/
9 lines
conf/
1 line
dev/
hwpmc/
9 lines
70 lines
725 lines

Diff 53159

View Options

sys/arm64/include/pmc_mdep.h

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
int env_verbosity; int env_verbosity;
static void usage(void); static void usage(void);
int int
main(int argc, char **argv) main(int argc, char **argv)
{ {
char *altpath, **ep, *p, **parg; char *altpath, **ep, *p, **parg, term;
char *cleanenv[1]; char *cleanenv[1];
int ch, want_clear; int ch, want_clear;
int rtrn; int rtrn;
altpath = NULL; altpath = NULL;
want_clear = 0; want_clear = 0;
while ((ch = getopt(argc, argv, "-iP:S:u:v")) != -1) term = '\n';
while ((ch = getopt(argc, argv, "-0iP:S:u:v")) != -1)
switch(ch) { switch(ch) {
case '-': case '-':
case 'i': case 'i':
want_clear = 1; want_clear = 1;
break; break;
case '0':
term = '\0';
break;
case 'P': case 'P':
altpath = strdup(optarg); altpath = strdup(optarg);
break; break;
case 'S': case 'S':
/* /*
* The -S option, for "split string on spaces, with * The -S option, for "split string on spaces, with
* support for some simple substitutions"... * support for some simple substitutions"...
*/ */
Show All 27 Lines if (env_verbosity)
fprintf(stderr, "#env setenv:\t%s\n", *argv); fprintf(stderr, "#env setenv:\t%s\n", *argv);
*p = '\0'; *p = '\0';
rtrn = setenv(*argv, p + 1, 1); rtrn = setenv(*argv, p + 1, 1);
*p = '='; *p = '=';
if (rtrn == -1) if (rtrn == -1)
err(EXIT_FAILURE, "setenv %s", *argv); err(EXIT_FAILURE, "setenv %s", *argv);
} }
if (*argv) { if (*argv) {
if (term == '\0')
errx(125, "cannot specify command with -0");
swillsUnsubmitted
Not Done
Inline Actions

I think maybe this should call exit(), perhaps with a non-zero exit, perhaps with 125 instead.

swills: I think maybe this should call `exit()`, perhaps with a non-zero exit, perhaps with 125 instead.
impUnsubmitted
Not Done
Inline Actions

what's a 125?

imp: what's a 125?
else {
if (altpath) if (altpath)
search_paths(altpath, argv); search_paths(altpath, argv);
if (env_verbosity) { if (env_verbosity) {
fprintf(stderr, "#env executing:\t%s\n", *argv); fprintf(stderr, "#env executing:\t%s\n", *argv);
for (parg = argv, argc = 0; *parg; parg++, argc++) for (parg = argv, argc = 0; *parg; parg++, argc++)
fprintf(stderr, "#env arg[%d]=\t'%s'\n", fprintf(stderr, "#env arg[%d]=\t'%s'\n",
argc, *parg); argc, *parg);
if (env_verbosity > 1) if (env_verbosity > 1)
sleep(1); sleep(1);
} }
execvp(*argv, argv); execvp(*argv, argv);
err(errno == ENOENT ? 127 : 126, "%s", *argv); err(errno == ENOENT ? 127 : 126, "%s", *argv);
} }
}
for (ep = environ; *ep; ep++) for (ep = environ; *ep; ep++)
(void)printf("%s\n", *ep); (void)printf("%s%c", *ep, term);
exit(0); exit(0);
} }
static void static void
usage(void) usage(void)
{ {
(void)fprintf(stderr, (void)fprintf(stderr,
"usage: env [-iv] [-P utilpath] [-S string] [-u name]\n" "usage: env [-0iv] [-P utilpath] [-S string] [-u name]\n"
" [name=value ...] [utility [argument ...]]\n"); " [name=value ...] [utility [argument ...]]\n");
exit(1); exit(1);
} }
View Options

sys/conf/files.arm64

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
int env_verbosity; int env_verbosity;
static void usage(void); static void usage(void);
int int
main(int argc, char **argv) main(int argc, char **argv)
{ {
char *altpath, **ep, *p, **parg; char *altpath, **ep, *p, **parg, term;
char *cleanenv[1]; char *cleanenv[1];
int ch, want_clear; int ch, want_clear;
int rtrn; int rtrn;
altpath = NULL; altpath = NULL;
want_clear = 0; want_clear = 0;
while ((ch = getopt(argc, argv, "-iP:S:u:v")) != -1) term = '\n';
while ((ch = getopt(argc, argv, "-0iP:S:u:v")) != -1)
switch(ch) { switch(ch) {
case '-': case '-':
case 'i': case 'i':
want_clear = 1; want_clear = 1;
break; break;
case '0':
term = '\0';
break;
case 'P': case 'P':
altpath = strdup(optarg); altpath = strdup(optarg);
break; break;
case 'S': case 'S':
/* /*
* The -S option, for "split string on spaces, with * The -S option, for "split string on spaces, with
* support for some simple substitutions"... * support for some simple substitutions"...
*/ */
Show All 27 Lines if (env_verbosity)
fprintf(stderr, "#env setenv:\t%s\n", *argv); fprintf(stderr, "#env setenv:\t%s\n", *argv);
*p = '\0'; *p = '\0';
rtrn = setenv(*argv, p + 1, 1); rtrn = setenv(*argv, p + 1, 1);
*p = '='; *p = '=';
if (rtrn == -1) if (rtrn == -1)
err(EXIT_FAILURE, "setenv %s", *argv); err(EXIT_FAILURE, "setenv %s", *argv);
} }
if (*argv) { if (*argv) {
if (term == '\0')
errx(125, "cannot specify command with -0");
swillsUnsubmitted
Not Done
Inline Actions

I think maybe this should call exit(), perhaps with a non-zero exit, perhaps with 125 instead.

swills: I think maybe this should call `exit()`, perhaps with a non-zero exit, perhaps with 125 instead.
impUnsubmitted
Not Done
Inline Actions

what's a 125?

imp: what's a 125?
else {
if (altpath) if (altpath)
search_paths(altpath, argv); search_paths(altpath, argv);
if (env_verbosity) { if (env_verbosity) {
fprintf(stderr, "#env executing:\t%s\n", *argv); fprintf(stderr, "#env executing:\t%s\n", *argv);
for (parg = argv, argc = 0; *parg; parg++, argc++) for (parg = argv, argc = 0; *parg; parg++, argc++)
fprintf(stderr, "#env arg[%d]=\t'%s'\n", fprintf(stderr, "#env arg[%d]=\t'%s'\n",
argc, *parg); argc, *parg);
if (env_verbosity > 1) if (env_verbosity > 1)
sleep(1); sleep(1);
} }
execvp(*argv, argv); execvp(*argv, argv);
err(errno == ENOENT ? 127 : 126, "%s", *argv); err(errno == ENOENT ? 127 : 126, "%s", *argv);
} }
}
for (ep = environ; *ep; ep++) for (ep = environ; *ep; ep++)
(void)printf("%s\n", *ep); (void)printf("%s%c", *ep, term);
exit(0); exit(0);
} }
static void static void
usage(void) usage(void)
{ {
(void)fprintf(stderr, (void)fprintf(stderr,
"usage: env [-iv] [-P utilpath] [-S string] [-u name]\n" "usage: env [-0iv] [-P utilpath] [-S string] [-u name]\n"
" [name=value ...] [utility [argument ...]]\n"); " [name=value ...] [utility [argument ...]]\n");
exit(1); exit(1);
} }
View Options

sys/dev/hwpmc/hwpmc_arm64.c

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
int env_verbosity; int env_verbosity;
static void usage(void); static void usage(void);
int int
main(int argc, char **argv) main(int argc, char **argv)
{ {
char *altpath, **ep, *p, **parg; char *altpath, **ep, *p, **parg, term;
char *cleanenv[1]; char *cleanenv[1];
int ch, want_clear; int ch, want_clear;
int rtrn; int rtrn;
altpath = NULL; altpath = NULL;
want_clear = 0; want_clear = 0;
while ((ch = getopt(argc, argv, "-iP:S:u:v")) != -1) term = '\n';
while ((ch = getopt(argc, argv, "-0iP:S:u:v")) != -1)
switch(ch) { switch(ch) {
case '-': case '-':
case 'i': case 'i':
want_clear = 1; want_clear = 1;
break; break;
case '0':
term = '\0';
break;
case 'P': case 'P':
altpath = strdup(optarg); altpath = strdup(optarg);
break; break;
case 'S': case 'S':
/* /*
* The -S option, for "split string on spaces, with * The -S option, for "split string on spaces, with
* support for some simple substitutions"... * support for some simple substitutions"...
*/ */
Show All 27 Lines if (env_verbosity)
fprintf(stderr, "#env setenv:\t%s\n", *argv); fprintf(stderr, "#env setenv:\t%s\n", *argv);
*p = '\0'; *p = '\0';
rtrn = setenv(*argv, p + 1, 1); rtrn = setenv(*argv, p + 1, 1);
*p = '='; *p = '=';
if (rtrn == -1) if (rtrn == -1)
err(EXIT_FAILURE, "setenv %s", *argv); err(EXIT_FAILURE, "setenv %s", *argv);
} }
if (*argv) { if (*argv) {
if (term == '\0')
errx(125, "cannot specify command with -0");
swillsUnsubmitted
Not Done
Inline Actions

I think maybe this should call exit(), perhaps with a non-zero exit, perhaps with 125 instead.

swills: I think maybe this should call `exit()`, perhaps with a non-zero exit, perhaps with 125 instead.
impUnsubmitted
Not Done
Inline Actions

what's a 125?

imp: what's a 125?
else {
if (altpath) if (altpath)
search_paths(altpath, argv); search_paths(altpath, argv);
if (env_verbosity) { if (env_verbosity) {
fprintf(stderr, "#env executing:\t%s\n", *argv); fprintf(stderr, "#env executing:\t%s\n", *argv);
for (parg = argv, argc = 0; *parg; parg++, argc++) for (parg = argv, argc = 0; *parg; parg++, argc++)
fprintf(stderr, "#env arg[%d]=\t'%s'\n", fprintf(stderr, "#env arg[%d]=\t'%s'\n",
argc, *parg); argc, *parg);
if (env_verbosity > 1) if (env_verbosity > 1)
sleep(1); sleep(1);
} }
execvp(*argv, argv); execvp(*argv, argv);
err(errno == ENOENT ? 127 : 126, "%s", *argv); err(errno == ENOENT ? 127 : 126, "%s", *argv);
} }
}
for (ep = environ; *ep; ep++) for (ep = environ; *ep; ep++)
(void)printf("%s\n", *ep); (void)printf("%s%c", *ep, term);
exit(0); exit(0);
} }
static void static void
usage(void) usage(void)
{ {
(void)fprintf(stderr, (void)fprintf(stderr,
"usage: env [-iv] [-P utilpath] [-S string] [-u name]\n" "usage: env [-0iv] [-P utilpath] [-S string] [-u name]\n"
" [name=value ...] [utility [argument ...]]\n"); " [name=value ...] [utility [argument ...]]\n");
exit(1); exit(1);
} }
View Options

sys/dev/hwpmc/hwpmc_cs.h

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
int env_verbosity; int env_verbosity;
static void usage(void); static void usage(void);
int int
main(int argc, char **argv) main(int argc, char **argv)
{ {
char *altpath, **ep, *p, **parg; char *altpath, **ep, *p, **parg, term;
char *cleanenv[1]; char *cleanenv[1];
int ch, want_clear; int ch, want_clear;
int rtrn; int rtrn;
altpath = NULL; altpath = NULL;
want_clear = 0; want_clear = 0;
while ((ch = getopt(argc, argv, "-iP:S:u:v")) != -1) term = '\n';
while ((ch = getopt(argc, argv, "-0iP:S:u:v")) != -1)
switch(ch) { switch(ch) {
case '-': case '-':
case 'i': case 'i':
want_clear = 1; want_clear = 1;
break; break;
case '0':
term = '\0';
break;
case 'P': case 'P':
altpath = strdup(optarg); altpath = strdup(optarg);
break; break;
case 'S': case 'S':
/* /*
* The -S option, for "split string on spaces, with * The -S option, for "split string on spaces, with
* support for some simple substitutions"... * support for some simple substitutions"...
*/ */
Show All 27 Lines if (env_verbosity)
fprintf(stderr, "#env setenv:\t%s\n", *argv); fprintf(stderr, "#env setenv:\t%s\n", *argv);
*p = '\0'; *p = '\0';
rtrn = setenv(*argv, p + 1, 1); rtrn = setenv(*argv, p + 1, 1);
*p = '='; *p = '=';
if (rtrn == -1) if (rtrn == -1)
err(EXIT_FAILURE, "setenv %s", *argv); err(EXIT_FAILURE, "setenv %s", *argv);
} }
if (*argv) { if (*argv) {
if (term == '\0')
errx(125, "cannot specify command with -0");
swillsUnsubmitted
Not Done
Inline Actions

I think maybe this should call exit(), perhaps with a non-zero exit, perhaps with 125 instead.

swills: I think maybe this should call `exit()`, perhaps with a non-zero exit, perhaps with 125 instead.
impUnsubmitted
Not Done
Inline Actions

what's a 125?

imp: what's a 125?
else {
if (altpath) if (altpath)
search_paths(altpath, argv); search_paths(altpath, argv);
if (env_verbosity) { if (env_verbosity) {
fprintf(stderr, "#env executing:\t%s\n", *argv); fprintf(stderr, "#env executing:\t%s\n", *argv);
for (parg = argv, argc = 0; *parg; parg++, argc++) for (parg = argv, argc = 0; *parg; parg++, argc++)
fprintf(stderr, "#env arg[%d]=\t'%s'\n", fprintf(stderr, "#env arg[%d]=\t'%s'\n",
argc, *parg); argc, *parg);
if (env_verbosity > 1) if (env_verbosity > 1)
sleep(1); sleep(1);
} }
execvp(*argv, argv); execvp(*argv, argv);
err(errno == ENOENT ? 127 : 126, "%s", *argv); err(errno == ENOENT ? 127 : 126, "%s", *argv);
} }
}
for (ep = environ; *ep; ep++) for (ep = environ; *ep; ep++)
(void)printf("%s\n", *ep); (void)printf("%s%c", *ep, term);
exit(0); exit(0);
} }
static void static void
usage(void) usage(void)
{ {
(void)fprintf(stderr, (void)fprintf(stderr,
"usage: env [-iv] [-P utilpath] [-S string] [-u name]\n" "usage: env [-0iv] [-P utilpath] [-S string] [-u name]\n"
" [name=value ...] [utility [argument ...]]\n"); " [name=value ...] [utility [argument ...]]\n");
exit(1); exit(1);
} }
View Options

sys/dev/hwpmc/hwpmc_cs.c

Loading...