Import libipt

[br]

Summary

Import Intel Processor Tracing library

Test Plan

world build run on amd64 host

[emaste]

lib/libipt/Makefile

14

are there c files in these include paths?

[br]

${LIBIPTSRC}/include/posix is not required in PATH

lib/libipt/Makefile

14

nope, but these are required for header files too

[emaste]

lib/libipt/Makefile

14

But make's .PATH doesn't affect compiler search paths for includes, they're handled only via CFLAGS+=-I....

[br]

lib/libipt/Makefile

14

This is for INCS=intel_pt.h ...
Else we get "make: don't know how to make intel-pt.h. Stop"

For example lib/libucl does the same.

[emaste]

lib/libipt/Makefile

14

Indeed, sorry I missed the INCS=

[br]

Add IPT entries to src.libnames.mk, bsd.libnames.mk

[br]

wrap lines in lib/libipt/Makefile

[emaste]

I agree with @kib that this should be a private lib

lib/libipt/Makefile

73

out of curiosity what warnings do we have at higher levels?

[emaste]

Oops, pasted in the wrong review.

[kib]

Where is the upstream ? I only found Intel® Processor Trace Decoder Library.
I would appreciate if the review would be split into vendor import and contrib merge, and then the second review with the FreeBSD changes over contrib + build glue.

[br]

In D12717#265981, @kib wrote:

Where is the upstream ? I only found Intel® Processor Trace Decoder Library.
I would appreciate if the review would be split into vendor import and contrib merge, and then the second review with the FreeBSD changes over contrib + build glue.

OK. Upstream is here https://github.com/01org/processor-trace

lib/libipt/Makefile

73

At least cast-align warnings (pt_ild.c has a cast from const uint8_t * to const int16_t *)