Page MenuHomeFreeBSD

Import libipt
ClosedPublic

Authored by br on Oct 18 2017, 1:02 PM.
Tags
None
Referenced Files
F131434533: D12717.diff
Wed, Oct 8, 12:54 AM
Unknown Object (File)
Thu, Oct 2, 9:30 PM
Unknown Object (File)
Sun, Sep 21, 6:06 AM
Unknown Object (File)
Fri, Sep 19, 9:10 PM
Unknown Object (File)
Sep 7 2025, 5:48 PM
Unknown Object (File)
Sep 4 2025, 6:30 PM
Unknown Object (File)
Sep 2 2025, 3:58 AM
Unknown Object (File)
Aug 24 2025, 4:55 AM
Subscribers

Details

Reviewers
emaste
jhb
br
Summary

Import Intel Processor Tracing library

Test Plan

world build run on amd64 host

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lib/libipt/Makefile
13

are there c files in these include paths?

${LIBIPTSRC}/include/posix is not required in PATH

lib/libipt/Makefile
13

nope, but these are required for header files too

lib/libipt/Makefile
13

But make's .PATH doesn't affect compiler search paths for includes, they're handled only via CFLAGS+=-I....

lib/libipt/Makefile
13

This is for INCS=intel_pt.h ...
Else we get "make: don't know how to make intel-pt.h. Stop"

For example lib/libucl does the same.

lib/libipt/Makefile
13

Indeed, sorry I missed the INCS=

Add IPT entries to src.libnames.mk, bsd.libnames.mk

wrap lines in lib/libipt/Makefile

I agree with @kib that this should be a private lib

lib/libipt/Makefile
74

out of curiosity what warnings do we have at higher levels?

Oops, pasted in the wrong review.

Where is the upstream ? I only found Intel® Processor Trace Decoder Library.
I would appreciate if the review would be split into vendor import and contrib merge, and then the second review with the FreeBSD changes over contrib + build glue.

In D12717#265981, @kib wrote:

Where is the upstream ? I only found Intel® Processor Trace Decoder Library.
I would appreciate if the review would be split into vendor import and contrib merge, and then the second review with the FreeBSD changes over contrib + build glue.

OK. Upstream is here https://github.com/01org/processor-trace

lib/libipt/Makefile
74

At least cast-align warnings (pt_ild.c has a cast from const uint8_t * to const int16_t *)

This revision is now accepted and ready to land.Apr 16 2018, 12:58 PM