Differential D18854

x86 busdma: fix mis-use of bus_addr_t where vm_paddr_t is assumed.
ClosedPublic
Actions

Authored by kib on Jan 16 2019, 6:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 10:34 PM

	Unknown Object (File)
	Thu, Apr 25, 10:34 PM

	Unknown Object (File)
	Thu, Apr 25, 9:30 PM

	Unknown Object (File)
	Thu, Apr 25, 9:30 PM

	Unknown Object (File)
	Thu, Apr 25, 7:26 AM

	Unknown Object (File)
	Thu, Apr 25, 5:43 AM

	Unknown Object (File)
	Thu, Apr 25, 1:16 AM

	Unknown Object (File)
	Tue, Apr 23, 10:14 AM

View All 28 Files

Subscribers

Details

Reviewers

jhb
markj

Commits

rS343147: i386/PAE busdma: allow more bounce pages.
rS343146: x86 busdma: fix mis-use of bus_addr_t where vm_paddr_t is assumed.

Summary

Right now bus_addr_t and vm_paddr_t are always aliases for the same underlying integer type on x86, which makes the interchange hard to detect. Shortly, i386 kernel would use uint64_t for vm_paddr_t to enable automatic use of PAE paging structures if hardware allows it, while bus_addr_t would be extended to 64bit only when PAE option is specified.

Fix all places that were identified as using bus_addr_t while page address was assumed. This was performed by testing the complete PAE merging patch on machine with > 4G of RAM enabled.

Tested by: pho (as part of the larger patch)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 16 2019, 6:32 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2019, 6:32 AM

Harbormaster completed remote builds in B21979: Diff 52884.Jan 16 2019, 6:32 AM

markj accepted this revision.Jan 16 2019, 5:38 PM

This revision is now accepted and ready to land.Jan 16 2019, 5:38 PM

Closed by commit rS343146: x86 busdma: fix mis-use of bus_addr_t where vm_paddr_t is assumed. (authored by kib). · Explain WhyJan 18 2019, 1:39 PM

This revision was automatically updated to reflect the committed changes.

kib reopened this revision.Jan 18 2019, 1:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2019, 1:43 PM

Closed by commit rS343147: i386/PAE busdma: allow more bounce pages. (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

x86/

include/

2 lines

x86/

busdma_bounce.c

21 lines

busdma_machdep.c

7 lines

Diff 52978

head/sys/x86/include/busdma_impl.h

Loading...

head/sys/x86/x86/busdma_bounce.c

Loading...

head/sys/x86/x86/busdma_machdep.c

Loading...