Page MenuHomeFreeBSD

x86 busdma: fix mis-use of bus_addr_t where vm_paddr_t is assumed.
ClosedPublic

Authored by kib on Jan 16 2019, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 23 2024, 5:36 AM
Unknown Object (File)
Oct 23 2024, 5:36 AM
Unknown Object (File)
Oct 23 2024, 5:36 AM
Unknown Object (File)
Oct 23 2024, 5:36 AM
Unknown Object (File)
Oct 23 2024, 5:17 AM
Unknown Object (File)
Oct 9 2024, 9:29 PM
Unknown Object (File)
Sep 24 2024, 12:46 PM
Unknown Object (File)
Sep 11 2024, 11:54 PM
Subscribers

Details

Summary

Right now bus_addr_t and vm_paddr_t are always aliases for the same underlying integer type on x86, which makes the interchange hard to detect. Shortly, i386 kernel would use uint64_t for vm_paddr_t to enable automatic use of PAE paging structures if hardware allows it, while bus_addr_t would be extended to 64bit only when PAE option is specified.

Fix all places that were identified as using bus_addr_t while page address was assumed. This was performed by testing the complete PAE merging patch on machine with > 4G of RAM enabled.

Tested by: pho (as part of the larger patch)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 16 2019, 5:38 PM
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2019, 1:43 PM
This revision was automatically updated to reflect the committed changes.