Page MenuHomeFreeBSD
Differential D18817

ixl(4): Fix handling data passed with ioctl from NVM update tool
ClosedPublic
Actions

Authored by kgalazka on Jan 11 2019, 8:57 AM.
Tags
None
Referenced Files
F163640438: D18817.id.diff
Sat, Jul 25, 2:33 AM
Unknown Object (File)
Tue, Jul 21, 4:30 PM
Unknown Object (File)
Sat, Jul 11, 7:11 PM
Unknown Object (File)
Thu, Jul 2, 4:56 PM
Unknown Object (File)
Jun 22 2026, 6:40 PM
Unknown Object (File)
Jun 19 2026, 2:25 PM
Unknown Object (File)
Jun 16 2026, 9:22 AM
Unknown Object (File)
Jun 13 2026, 9:07 PM
View All Files
Subscribers
ae
erj
imp

Details

Reviewers
shurd
sbruno
jeffrey.e.pieper_intel.com
Group Reviewers
Intel Networking
Commits
rS344105: MFC: r343372
rS344104: MFC: r343372
rS343372: ixl(4): Fix handling data passed with ioctl from NVM update tool
Summary

Ensure that whole data buffer passed from NVM update tool
was copied in to kernel space and copied out back.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21923
Build 21167: arc lint + arc unit

Event Timeline

kgalazka created this revision.Jan 11 2019, 8:57 AM
Herald added a subscriber: ae. · View Herald TranscriptJan 11 2019, 8:57 AM
Harbormaster completed remote builds in B21923: Diff 52761.Jan 11 2019, 8:57 AM
erj added a subscriber: erj.Jan 11 2019, 6:49 PM

Does anyone on this review know why this is necessary on 12.0+? I think we were supposed to be doing this in the first place, but I don't know why this stopped working.

jeffrey.e.pieper_intel.com accepted this revision.Jan 23 2019, 5:08 PM
This revision is now accepted and ready to land.Jan 23 2019, 5:08 PM
Closed by commit rS343372: ixl(4): Fix handling data passed with ioctl from NVM update tool (authored by erj). · Explain WhyJan 24 2019, 1:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJan 24 2019, 1:08 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
ixl/
69 lines

Diff 52761

View Options

sys/dev/ixl/ixl_pf_main.c

Loading...