Page MenuHomeFreeBSD
Differential D18812

Fix errno values returned from DUMMY_XATTR linuxulator calls.
ClosedPublic
Actions

Authored by fsu on Jan 10 2019, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 5:09 PM
Unknown Object (File)
Feb 14 2025, 10:21 PM
Unknown Object (File)
Feb 2 2025, 1:06 AM
Unknown Object (File)
Jan 18 2025, 4:27 AM
Unknown Object (File)
Jan 12 2025, 12:44 AM
Unknown Object (File)
Jan 1 2025, 10:10 PM
Unknown Object (File)
Nov 28 2024, 5:23 PM
Unknown Object (File)
Oct 4 2024, 7:11 PM
View All 38 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
markj
manu
Commits
rS342999: MFC r342933:
rS342998: MFC r342933:
rS342933: Fix errno values returned from DUMMY_XATTR linuxulator calls
Summary

The review is fix for Bug 234713.

Test Plan

The simple test program was written to compile on linux and run on linuxulator to be sure, that correct values are returned:

test_xattr.c983 BDownload

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fsu created this revision.Jan 10 2019, 5:24 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 10 2019, 5:24 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
markj accepted this revision.Jan 10 2019, 5:30 PM

Thanks.

The duplication of these stubs is rather unfortunate...

This revision is now accepted and ready to land.Jan 10 2019, 5:30 PM
fsu added a comment.Jan 10 2019, 5:46 PM
In D18812#401528, @markj wrote:

Thanks.

The duplication of these stubs is rather unfortunate...

Yep, it could be moved to linux_util.h. Together with DUMMY macro declaration .
The r326282, which cause the user bug was part of my effort to implement xattrs in the linuxulator some time ago, but the process was stacked.
My be I will get back to this topic in the future).

Closed by commit rS342933: Fix errno values returned from DUMMY_XATTR linuxulator calls (authored by fsu). · Explain WhyJan 11 2019, 7:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
linux/
2 lines
linux32/
2 lines
arm64/
linux/
2 lines
i386/
linux/
2 lines

Diff 52759

View Options

head/sys/amd64/linux/linux_dummy.c

Show All 18 Lines
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd July 9, 2016 .Dd February 27, 2017
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm bhyve .Nm bhyve
.Nd "run a guest operating system inside a virtual machine" .Nd "run a guest operating system inside a virtual machine"
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl abehuwxACHPSWY .Op Fl abehuwxACHPSWY
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.It Li passthru .It Li passthru
PCI pass-through device. PCI pass-through device.
.It Li virtio-net .It Li virtio-net
Virtio network interface. Virtio network interface.
.It Li virtio-blk .It Li virtio-blk
Virtio block storage interface. Virtio block storage interface.
.It Li virtio-rnd .It Li virtio-rnd
Virtio RNG interface. Virtio RNG interface.
.It Li virtio-console
Virtio console interface, which exposes multiple ports
to the guest in the form of simple char devices for simple IO
between the guest and host userspaces.
.It Li ahci .It Li ahci
AHCI controller attached to arbitrary devices. AHCI controller attached to arbitrary devices.
.It Li ahci-cd .It Li ahci-cd
AHCI controller attached to an ATAPI CD/DVD. AHCI controller attached to an ATAPI CD/DVD.
.It Li ahci-hd .It Li ahci-hd
AHCI controller attached to a SATA hard-drive. AHCI controller attached to a SATA hard-drive.
.It Li e1000 .It Li e1000
Intel e82545 network interface. Intel e82545 network interface.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
Guest memory must be wired using the Guest memory must be wired using the
.Fl S .Fl S
option when a pass-through device is configured. option when a pass-through device is configured.
.Pp .Pp
The host device must have been reserved at boot-time using the The host device must have been reserved at boot-time using the
.Va pptdev .Va pptdev
loader variable as described in loader variable as described in
.Xr vmm 4 . .Xr vmm 4 .
.Pp
Virtio console devices:
.Bl -tag -width 10n
.It Li port1= Ns Pa /path/to/port1.sock Ns ,anotherport= Ns Pa ...
A maximum of 16 ports per device can be created.
Every port is named and corresponds to a Unix domain socket created by
.Nm .
.Nm
accepts at most one connection per port at a time.
.Pp
Limitations:
.Bl -bullet -offset 2n
.It
Due to lack of destructors in
.Nm ,
sockets on the filesystem must be cleaned up manually after
.Nm
exits.
.It
There is no way to use the "console port" feature, nor the console port
resize as of now.
wblockUnsubmitted
Not Done
Inline Actions

Recommend "at present" rather than "as of now".

wblock: Recommend "at present" rather than "as of now".
novelAuthorUnsubmitted
Not Done
Inline Actions

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

novel: Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you…
wblockUnsubmitted
Not Done
Inline Actions

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

wblock: Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no…
novelAuthorUnsubmitted
Not Done
Inline Actions

Thanks, I've just committed that.

novel: Thanks, I've just committed that.
.It
Emergency write is advertised, but no-op as of now.
wblockUnsubmitted
Not Done
Inline Actions

Likewise, "at present" is simpler and clearer.

wblock: Likewise, "at present" is simpler and clearer.
.El
.El
.El .El
.It Fl S .It Fl S
Wire guest memory. Wire guest memory.
.It Fl u .It Fl u
RTC keeps UTC time. RTC keeps UTC time.
.It Fl U Ar uuid .It Fl U Ar uuid
Set the universally unique identifier Set the universally unique identifier
.Pq UUID .Pq UUID
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

head/sys/amd64/linux32/linux32_dummy.c

Show All 18 Lines
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd July 9, 2016 .Dd February 27, 2017
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm bhyve .Nm bhyve
.Nd "run a guest operating system inside a virtual machine" .Nd "run a guest operating system inside a virtual machine"
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl abehuwxACHPSWY .Op Fl abehuwxACHPSWY
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.It Li passthru .It Li passthru
PCI pass-through device. PCI pass-through device.
.It Li virtio-net .It Li virtio-net
Virtio network interface. Virtio network interface.
.It Li virtio-blk .It Li virtio-blk
Virtio block storage interface. Virtio block storage interface.
.It Li virtio-rnd .It Li virtio-rnd
Virtio RNG interface. Virtio RNG interface.
.It Li virtio-console
Virtio console interface, which exposes multiple ports
to the guest in the form of simple char devices for simple IO
between the guest and host userspaces.
.It Li ahci .It Li ahci
AHCI controller attached to arbitrary devices. AHCI controller attached to arbitrary devices.
.It Li ahci-cd .It Li ahci-cd
AHCI controller attached to an ATAPI CD/DVD. AHCI controller attached to an ATAPI CD/DVD.
.It Li ahci-hd .It Li ahci-hd
AHCI controller attached to a SATA hard-drive. AHCI controller attached to a SATA hard-drive.
.It Li e1000 .It Li e1000
Intel e82545 network interface. Intel e82545 network interface.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
Guest memory must be wired using the Guest memory must be wired using the
.Fl S .Fl S
option when a pass-through device is configured. option when a pass-through device is configured.
.Pp .Pp
The host device must have been reserved at boot-time using the The host device must have been reserved at boot-time using the
.Va pptdev .Va pptdev
loader variable as described in loader variable as described in
.Xr vmm 4 . .Xr vmm 4 .
.Pp
Virtio console devices:
.Bl -tag -width 10n
.It Li port1= Ns Pa /path/to/port1.sock Ns ,anotherport= Ns Pa ...
A maximum of 16 ports per device can be created.
Every port is named and corresponds to a Unix domain socket created by
.Nm .
.Nm
accepts at most one connection per port at a time.
.Pp
Limitations:
.Bl -bullet -offset 2n
.It
Due to lack of destructors in
.Nm ,
sockets on the filesystem must be cleaned up manually after
.Nm
exits.
.It
There is no way to use the "console port" feature, nor the console port
resize as of now.
wblockUnsubmitted
Not Done
Inline Actions

Recommend "at present" rather than "as of now".

wblock: Recommend "at present" rather than "as of now".
novelAuthorUnsubmitted
Not Done
Inline Actions

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

novel: Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you…
wblockUnsubmitted
Not Done
Inline Actions

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

wblock: Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no…
novelAuthorUnsubmitted
Not Done
Inline Actions

Thanks, I've just committed that.

novel: Thanks, I've just committed that.
.It
Emergency write is advertised, but no-op as of now.
wblockUnsubmitted
Not Done
Inline Actions

Likewise, "at present" is simpler and clearer.

wblock: Likewise, "at present" is simpler and clearer.
.El
.El
.El .El
.It Fl S .It Fl S
Wire guest memory. Wire guest memory.
.It Fl u .It Fl u
RTC keeps UTC time. RTC keeps UTC time.
.It Fl U Ar uuid .It Fl U Ar uuid
Set the universally unique identifier Set the universally unique identifier
.Pq UUID .Pq UUID
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

head/sys/arm64/linux/linux_dummy.c

Show All 18 Lines
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd July 9, 2016 .Dd February 27, 2017
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm bhyve .Nm bhyve
.Nd "run a guest operating system inside a virtual machine" .Nd "run a guest operating system inside a virtual machine"
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl abehuwxACHPSWY .Op Fl abehuwxACHPSWY
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.It Li passthru .It Li passthru
PCI pass-through device. PCI pass-through device.
.It Li virtio-net .It Li virtio-net
Virtio network interface. Virtio network interface.
.It Li virtio-blk .It Li virtio-blk
Virtio block storage interface. Virtio block storage interface.
.It Li virtio-rnd .It Li virtio-rnd
Virtio RNG interface. Virtio RNG interface.
.It Li virtio-console
Virtio console interface, which exposes multiple ports
to the guest in the form of simple char devices for simple IO
between the guest and host userspaces.
.It Li ahci .It Li ahci
AHCI controller attached to arbitrary devices. AHCI controller attached to arbitrary devices.
.It Li ahci-cd .It Li ahci-cd
AHCI controller attached to an ATAPI CD/DVD. AHCI controller attached to an ATAPI CD/DVD.
.It Li ahci-hd .It Li ahci-hd
AHCI controller attached to a SATA hard-drive. AHCI controller attached to a SATA hard-drive.
.It Li e1000 .It Li e1000
Intel e82545 network interface. Intel e82545 network interface.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
Guest memory must be wired using the Guest memory must be wired using the
.Fl S .Fl S
option when a pass-through device is configured. option when a pass-through device is configured.
.Pp .Pp
The host device must have been reserved at boot-time using the The host device must have been reserved at boot-time using the
.Va pptdev .Va pptdev
loader variable as described in loader variable as described in
.Xr vmm 4 . .Xr vmm 4 .
.Pp
Virtio console devices:
.Bl -tag -width 10n
.It Li port1= Ns Pa /path/to/port1.sock Ns ,anotherport= Ns Pa ...
A maximum of 16 ports per device can be created.
Every port is named and corresponds to a Unix domain socket created by
.Nm .
.Nm
accepts at most one connection per port at a time.
.Pp
Limitations:
.Bl -bullet -offset 2n
.It
Due to lack of destructors in
.Nm ,
sockets on the filesystem must be cleaned up manually after
.Nm
exits.
.It
There is no way to use the "console port" feature, nor the console port
resize as of now.
wblockUnsubmitted
Not Done
Inline Actions

Recommend "at present" rather than "as of now".

wblock: Recommend "at present" rather than "as of now".
novelAuthorUnsubmitted
Not Done
Inline Actions

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

novel: Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you…
wblockUnsubmitted
Not Done
Inline Actions

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

wblock: Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no…
novelAuthorUnsubmitted
Not Done
Inline Actions

Thanks, I've just committed that.

novel: Thanks, I've just committed that.
.It
Emergency write is advertised, but no-op as of now.
wblockUnsubmitted
Not Done
Inline Actions

Likewise, "at present" is simpler and clearer.

wblock: Likewise, "at present" is simpler and clearer.
.El
.El
.El .El
.It Fl S .It Fl S
Wire guest memory. Wire guest memory.
.It Fl u .It Fl u
RTC keeps UTC time. RTC keeps UTC time.
.It Fl U Ar uuid .It Fl U Ar uuid
Set the universally unique identifier Set the universally unique identifier
.Pq UUID .Pq UUID
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

head/sys/i386/linux/linux_dummy.c

Show All 18 Lines
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd July 9, 2016 .Dd February 27, 2017
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm bhyve .Nm bhyve
.Nd "run a guest operating system inside a virtual machine" .Nd "run a guest operating system inside a virtual machine"
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl abehuwxACHPSWY .Op Fl abehuwxACHPSWY
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.It Li passthru .It Li passthru
PCI pass-through device. PCI pass-through device.
.It Li virtio-net .It Li virtio-net
Virtio network interface. Virtio network interface.
.It Li virtio-blk .It Li virtio-blk
Virtio block storage interface. Virtio block storage interface.
.It Li virtio-rnd .It Li virtio-rnd
Virtio RNG interface. Virtio RNG interface.
.It Li virtio-console
Virtio console interface, which exposes multiple ports
to the guest in the form of simple char devices for simple IO
between the guest and host userspaces.
.It Li ahci .It Li ahci
AHCI controller attached to arbitrary devices. AHCI controller attached to arbitrary devices.
.It Li ahci-cd .It Li ahci-cd
AHCI controller attached to an ATAPI CD/DVD. AHCI controller attached to an ATAPI CD/DVD.
.It Li ahci-hd .It Li ahci-hd
AHCI controller attached to a SATA hard-drive. AHCI controller attached to a SATA hard-drive.
.It Li e1000 .It Li e1000
Intel e82545 network interface. Intel e82545 network interface.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
Guest memory must be wired using the Guest memory must be wired using the
.Fl S .Fl S
option when a pass-through device is configured. option when a pass-through device is configured.
.Pp .Pp
The host device must have been reserved at boot-time using the The host device must have been reserved at boot-time using the
.Va pptdev .Va pptdev
loader variable as described in loader variable as described in
.Xr vmm 4 . .Xr vmm 4 .
.Pp
Virtio console devices:
.Bl -tag -width 10n
.It Li port1= Ns Pa /path/to/port1.sock Ns ,anotherport= Ns Pa ...
A maximum of 16 ports per device can be created.
Every port is named and corresponds to a Unix domain socket created by
.Nm .
.Nm
accepts at most one connection per port at a time.
.Pp
Limitations:
.Bl -bullet -offset 2n
.It
Due to lack of destructors in
.Nm ,
sockets on the filesystem must be cleaned up manually after
.Nm
exits.
.It
There is no way to use the "console port" feature, nor the console port
resize as of now.
wblockUnsubmitted
Not Done
Inline Actions

Recommend "at present" rather than "as of now".

wblock: Recommend "at present" rather than "as of now".
novelAuthorUnsubmitted
Not Done
Inline Actions

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

novel: Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you…
wblockUnsubmitted
Not Done
Inline Actions

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

wblock: Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no…
novelAuthorUnsubmitted
Not Done
Inline Actions

Thanks, I've just committed that.

novel: Thanks, I've just committed that.
.It
Emergency write is advertised, but no-op as of now.
wblockUnsubmitted
Not Done
Inline Actions

Likewise, "at present" is simpler and clearer.

wblock: Likewise, "at present" is simpler and clearer.
.El
.El
.El .El
.It Fl S .It Fl S
Wire guest memory. Wire guest memory.
.It Fl u .It Fl u
RTC keeps UTC time. RTC keeps UTC time.
.It Fl U Ar uuid .It Fl U Ar uuid
Set the universally unique identifier Set the universally unique identifier
.Pq UUID .Pq UUID
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines