Fix errno values returned from DUMMY_XATTR linuxulator calls.
ClosedPublic
Actions

Authored by fsu on Jan 10 2019, 5:24 PM.

Details

Reviewers

markj
manu

Commits

rS342999: MFC r342933:
rS342998: MFC r342933:
rS342933: Fix errno values returned from DUMMY_XATTR linuxulator calls

Summary

The review is fix for Bug 234713.

Test Plan

The simple test program was written to compile on linux and run on linuxulator to be sure, that correct values are returned:

test_xattr.c983 BDownload

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fsu created this revision.Jan 10 2019, 5:24 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 10 2019, 5:24 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

Thanks.

The duplication of these stubs is rather unfortunate...

This revision is now accepted and ready to land.Jan 10 2019, 5:30 PM

In D18812#401528, @markj wrote:

Thanks.

The duplication of these stubs is rather unfortunate...

Yep, it could be moved to linux_util.h. Together with DUMMY macro declaration .
The r326282, which cause the user bug was part of my effort to implement xattrs in the linuxulator some time ago, but the process was stacked.
My be I will get back to this topic in the future).

Closed by commit rS342933: Fix errno values returned from DUMMY_XATTR linuxulator calls (authored by fsu). · Explain WhyJan 11 2019, 7:58 AM

This revision was automatically updated to reflect the committed changes.